Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test with valgrind #233

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Unit test with valgrind #233

merged 3 commits into from
Mar 30, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Mar 30, 2023 •
edited
Loading

This PR attempts to fix #232 by switching from inet_ntoa to inet_ntop.
In addition, it

  • restructures the current unit tests and introduces unit tests for assemble_tcp_address.
  • adds running the unit tests with valgrind to detect memory leaks in the workflow

@engelmi
restructured unit tests of libhirte
b19cb25 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
added valgrind wrapper to meson test and introduced gh workflow test …
78e4efc 
…step

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi force-pushed the unit-test-with-valgrind branch 2 times, most recently from 6f6126d to 60ba89f Compare March 30, 2023 12:23
mwperina
mwperina approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@engelmi
switch from inet_ntoa to inet_ntop
ca9ee42 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi merged commit af53c70 into main Mar 30, 2023
@engelmi engelmi deleted the unit-test-with-valgrind branch March 30, 2023 13:20
@engelmi engelmi mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sdunnagan sdunnagan Awaiting requested review from sdunnagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fedora rpminspect complains about the usage of inet_ntoa
2 participants
@engelmi @mwperina