Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup conf and man pages #235

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

rhatdan
Copy link
Contributor

@rhatdan rhatdan commented Apr 3, 2023

Identify in the hire-agent man page where the /etc/hirte/agent.conf file is supposed to be installed.

Also don't go over 120 characters in the conf files, to make them easier to view in terminals as well as editors.

Add builtin default settings to conf files so users have better idea of what is set when not commented out.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to use this prehistoric limit of 80 characters per line? Most of the people I know as using 120 chars per line or even more, that's why we for example have a rule to check 120 chars per line in all MD files

config/agent/agent.conf Show resolved Hide resolved
doc/man/hirte-agent.conf.5.md Outdated Show resolved Hide resolved
@rhatdan
Copy link
Contributor Author

rhatdan commented Apr 4, 2023

Do we really need to use this prehistoric limit of 80 characters per line? Most of the people I know as using 120 chars per line or even more, that's why we for example have a rule to check 120 chars per line in all MD files

When I open a terminal it defaults to 80 char, so VI and Emacs default to 80 char.
If terminal and editors don't change their defaults, I don't see why we should.

@mwperina
Copy link
Member

mwperina commented Apr 4, 2023

Do we really need to use this prehistoric limit of 80 characters per line? Most of the people I know as using 120 chars per line or even more, that's why we for example have a rule to check 120 chars per line in all MD files

When I open a terminal it defaults to 80 char, so VI and Emacs default to 80 char. If terminal and editors don't change their defaults, I don't see why we should.

I personally don't like switching back to 80 chars per line, but if that's a team decision, I will not object

@rhatdan
Copy link
Contributor Author

rhatdan commented Apr 4, 2023

@alexlarsson @pypingou @engelmi what is your opinion on the 80 chars versus 120?

@pypingou
Copy link
Member

pypingou commented Apr 6, 2023

@alexlarsson @pypingou @engelmi what is your opinion on the 80 chars versus 120?

I'm an old-timer and still use an 80 characters line. I also just find it easier to read smaller lines than longer ones.

config/agent/agent.conf Outdated Show resolved Hide resolved
@ygalblum
Copy link
Contributor

@alexlarsson @pypingou @engelmi what is your opinion on the 80 chars versus 120?

I think 120 is short enough. But, if people prefer 80 I won't object

Identify in the hire-agent man page where the /etc/hirte/agent.conf file
is supposed to be installed.

Also don't go over 120 characters in the conf files, to make them easier
to view in terminals as well as editors.

Add builtin default settings to conf files so users have better idea of
what is set when not commented out.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Contributor Author

rhatdan commented Apr 12, 2023

@mwperina You win, I moved everything to 120 chars. PTAL

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ygalblum ygalblum merged commit 6ff92f1 into eclipse-bluechi:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants