SELinux RPM - set selinuxtype to targeted #242
Conversation
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
|
The definition of |
|
@rhatdan PTAL |
| @@ -103,6 +103,8 @@ Requires: selinux-policy >= %{_selinux_policy_version} | |||
|
|
|||
| Requires(post): policycoreutils | |||
|
|
|||
| %global selinuxtype targeted | |||
There was a problem hiding this comment.
Hmm, I somehow missed that :-( even though it's mentioned in selinux packaging guidelines:
https://fedoraproject.org/wiki/SELinux_Policy_Modules_Packaging_Draft#Building_the_Policy_Modules
So is targeted enough or do we need to add also mls to the list?
Also as this is global option, could you please move it to the beginning of the spec file?
There was a problem hiding this comment.
So is targeted enough or do we need to add also mls to the list?
That's why I wanted to get input from @rhatdan
Also as this is global option, could you please move it to the beginning of the spec file?
Don't you think it's more readable when it's defined next to the sub-package it belongs to?
There was a problem hiding this comment.
Let's leave it as targeted. We don't plan on supporting any other form of SELinux policy especially not MLS.
|
LGTM |
The policy installation command in the
poststep uses this global without setting it. As a result, the policy does not get installed