Better default dbus policy #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing policy allowed anyone to send messages to hirte, which isn't ideal. It also isn't a huge issue as the default policy disallows sending any method calls even if you are allowed to send messages in general. However, it seems better to disallow messages in general, and just open up a few specific methods. This change allows the basic introspection but nothing more. This is a bit more limited than what the systemd configuration uses, as that allows anyone to use a lot of read-only APIs. However, readonly access to hirte would be give read access to other machines too, so it makes sense to be more limited. Signed-off-by: Alexander Larsson <alexl@redhat.com>
alexlarsson
requested review from
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
engelmi
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing policy allowed anyone to send messages to hirte, which isn't ideal. It also isn't a huge issue as the default policy disallows sending any method calls even if you are allowed to send messages in general.
However, it seems better to disallow messages in general, and just open up a few specific methods. This change allows the basic introspection but nothing more.
This is a bit more limited than what the systemd configuration uses, as that allows anyone to use a lot of read-only APIs. However, readonly access to hirte would be give read access to other machines too, so it makes sense to be more limited.