Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup e2e tests #264

Merged
merged 6 commits into from
May 2, 2023
Merged

Cleanup e2e tests #264

merged 6 commits into from
May 2, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Apr 28, 2023

This PR cleans up a bit the e2e tests, including the removal of unused imports, typing and automatic code formatting.

@engelmi
merged gitignore files
6e4dbeb 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi requested review from mwperina and Yarboa May 2, 2023 06:39
mwperina
mwperina requested changes May 2, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types definition for parameters and functions are great, I didn't know that there's a way to do that in python

tests/README.md Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/hirte_tests/gather/journal.py Show resolved Hide resolved
tests/hirte_tests/provision/containers.py Show resolved Hide resolved
tests/tests/tier0/hirte-agent-started-and-connected/test_agent_started_and_connected.py Show resolved Hide resolved
@engelmi
added requirements.txt to install e2e tests packages and updated readmes
7fdf68a 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
add autopep8 for unified code style and apply to files
3fd520a 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
cleanup imports
728d81c 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
added typing to functions
0eb170a 
Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi
fix race condition when starting hirte service and check it runs
5b0767d 
Signed-off-by: Michael Engel <mengel@redhat.com>
mwperina
mwperina approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@engelmi engelmi merged commit cc9eec5 into eclipse-bluechi:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sdunnagan sdunnagan Awaiting requested review from sdunnagan

@Yarboa Yarboa Awaiting requested review from Yarboa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engelmi @mwperina