Hirtectl - Fix endless loop in status call #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
Change types to size_t Keep all variables values positive Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
ygalblum
force-pushed
the
hirtectl-status-loop
branch
from
17b3859
to
b51d47f
Compare
engelmi
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
LGTM
Could we test this by replacing this line in the integration tests with the usage of hirtectl? Just querying and getting a response should be enough.
|
lgtm |
|
LGTM |
|
If we plan to release a 0.4.x, this should be part of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change types to size_t
Keep all variables values positive