Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config.h and config.c with parsing function for nodes and orch. #47

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Dec 20, 2022

Used inih for parsing. For parsing ini file use parsing_ini_file_orch or parsing_ini_file_node. Also added structure configuration_node and configuration_orch to save the ini file data.

Edit: re-opened from #27

Copy link
Member Author

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hashmap doesn't get freed and leaks memory, currently. We should fix this.

@engelmi engelmi marked this pull request as draft January 2, 2023 15:09
@ArtiomDivak ArtiomDivak force-pushed the parse-ini-file branch 2 times, most recently from ef147c6 to e0267d6 Compare January 3, 2023 11:16
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific work Artiom!

src/ini/config.c Outdated Show resolved Hide resolved
src/ini/config.c Outdated Show resolved Hide resolved
src/ini/hashmap/hashmap.h Outdated Show resolved Hide resolved
src/ini/config.c Outdated Show resolved Hide resolved
@ArtiomDivak ArtiomDivak force-pushed the parse-ini-file branch 5 times, most recently from 087c845 to 641f851 Compare January 8, 2023 08:55
Used inih for parsing. For parsing ini file use
parsing_ini_file_orch or parsing_ini_file_node.
Also added structure configuration_node and
configuration_orch to save the ini file data.
binchihua/src/ini/config.c Outdated Show resolved Hide resolved
Signed-off-by: Michael Engel <mengel@redhat.com>
Signed-off-by: Michael Engel <mengel@redhat.com>
@ArtiomDivak ArtiomDivak marked this pull request as ready for review January 9, 2023 12:39
@ArtiomDivak ArtiomDivak merged commit 6d5a057 into main Jan 9, 2023
@engelmi engelmi deleted the parse-ini-file branch January 17, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants