Python bindings in integration tests #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
ygalblum
reviewed
Aug 21, 2023
mwperina
reviewed
Aug 21, 2023
engelmi
force-pushed
the
python-bindings-in-integration-tests
branch
3 times, most recently
from
62cff80
to
4cfbd85
Compare
This was
linked to
issues
Aug 21, 2023
pypingou
reviewed
Aug 21, 2023
engelmi
force-pushed
the
python-bindings-in-integration-tests
branch
3 times, most recently
from
2f523ce
to
29fe5cf
Compare
engelmi
force-pushed
the
python-bindings-in-integration-tests
branch
2 times, most recently
from
6981ed6
to
3ff88cd
Compare
ygalblum
reviewed
Aug 22, 2023
During the renaming, the data file for the internal metrics interface on the agent has dropped the .internal. part - this causes the auto-generation to fail. Re-adding it. Signed-off-by: Michael Engel <mengel@redhat.com>
The skeleton for generating get functions for properties is missing a return statement, resulting in a None return value. This commit adds it and re-generates the bindings Signed-off-by: Michael Engel <mengel@redhat.com>
Added the python3-bluechi package to be installed in the local and snapshot container image and the required dasbus dependency in the base image so that the bindings can be used in the integration tests. Since there is a breaking change in dasbas@v1.7 in the naming of a data type, this import is wrapped with a try so that both versions can be supported. Signed-off-by: Michael Engel <mengel@redhat.com>
Signed-off-by: Michael Engel <mengel@redhat.com>
Fixes #411. The python bindings access the system bus where the bluechi controller is running. Therefore, it is required to run in inside the container for the integration test. To enable this, a helper function has been implemented and used for the monitor open-close test. Signed-off-by: Michael Engel <mengel@redhat.com>
Addresses #419 by listening for the node state changed signal and stopping the bluechi-agent service. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
python-bindings-in-integration-tests
branch
from
3ff88cd
to
86ce2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #411 and #419 (partially).
It introduces the python3-bluechi in the integration tests to be able to easily use the public D-Bus API of the bluechi controller. For this, a separate python script needs to be "injected" into the controller container - this PR adds a function to do this easily.
It also fixes a wrongly renamed data file - where the internal metrics API was missing the
internalpart. In addition, a missing return statement in the generator skeleton for getting properties has been added. After both fixes, the python bindings were re-generated.