Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbus connection to orchestrator #5

Merged
merged 4 commits into from
Dec 6, 2022
Merged

dbus connection to orchestrator #5

merged 4 commits into from
Dec 6, 2022

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Dec 1, 2022 •
edited
Loading

This PR fixes #11 by

  • getting the host and port via cli options (-h and -p)
  • implementing a setup function for the peer dbus to the orchestrator and using the parsed host:port
  • updated README
  • fixes an out-of-scope bug for the fd of the tcp master socket

@engelmi engelmi force-pushed the sdbus-connection-to-orchestrator branch from 794ab25 to f285bca Compare December 2, 2022 10:54
@engelmi engelmi marked this pull request as ready for review December 2, 2022 13:14
@engelmi engelmi changed the title added cli options for node dbus connection to orchestrator Dec 2, 2022
@engelmi engelmi force-pushed the sdbus-connection-to-orchestrator branch from 9ce9826 to b220edc Compare December 5, 2022 10:11
mkemel
mkemel approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe @sdunnagan should also look before merging?

src/node/opt.c Show resolved Hide resolved
@sdunnagan sdunnagan self-requested a review December 5, 2022 19:37
@engelmi engelmi merged commit 488f114 into main Dec 6, 2022
@engelmi engelmi deleted the sdbus-connection-to-orchestrator branch December 6, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darth-Mera Darth-Mera Darth-Mera left review comments

@sdunnagan sdunnagan sdunnagan approved these changes

@mkemel mkemel mkemel approved these changes

@ArtiomDivak ArtiomDivak Awaiting requested review from ArtiomDivak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node: connect to orchestrator
4 participants
@engelmi @sdunnagan @mkemel @Darth-Mera