Extend cfg unit tests #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates: #403 Added unit tests for loading a configuration file with - multiline support - calling the function twice overrides only existing key-values Signed-off-by: Michael Engel <mengel@redhat.com>
Split cfg_test.c into multiple files based on the function under test to reduce file size and complexity. Also replaced usage of strcmp with streq from own library. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
requested review from
alexlarsson,
mkemel,
rhatdan and
sdunnagan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #403.
This PR extends the unit tests for the configuration by testing
cfg_load_from_filemultiple times on the sameconfiginstance (should overwrite values for already existing keys)It also splits up the
cfg_test.cinto smaller source files based on the function under test.