Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a status and disconnected timestamp property to the agent interface #558

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Sep 11, 2023

Fixes #543

In order to enable other applications on the managed node to react to connection loss of the agent with the controller, add two new properties: Status and DisconnectTimestamp
If the status will change, the agent will emit a property changed signal on which other applications can listen. To provide information for later when the disconnect happened, the timestamp property can be queried.
This change also includes extending the D-Bus API description and adding an integration test to it.

Fixes #543
In order to enable other applications on the managed node to react
to connection loss of the agent with the controller, add two new
properties: Status and DisconnectTimestamp
If the status will change, the agent will emit a property changed
signal on which other applications can listen. To provide information
for later when the disconnect happened, the timestamp property
can be queried.
This change also includes extending the D-Bus API description and
adding an integration test to it.

Signed-off-by: Michael Engel <mengel@redhat.com>
Copy link
Contributor

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mkemel mkemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit 05cbd9a into main Sep 12, 2023
10 checks passed
@engelmi engelmi deleted the agent-add-disconnect-signal branch September 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does bluechi-agent send signal on disconnect?
4 participants