-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save .gcno files after meson build #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
September 20, 2023 09:07
ArtiomDivak
force-pushed
the
issue-397
branch
from
September 20, 2023 09:10
69a0479
to
66079b7
Compare
mwperina
requested changes
Sep 20, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
3 times, most recently
from
September 20, 2023 11:41
ed44357
to
1983e17
Compare
mwperina
reviewed
Sep 20, 2023
mwperina
reviewed
Sep 20, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
2 times, most recently
from
September 20, 2023 12:39
3919b5e
to
8825de6
Compare
mwperina
requested changes
Sep 20, 2023
ArtiomDivak
force-pushed
the
issue-397
branch
2 times, most recently
from
September 21, 2023 03:49
bf16f65
to
5d739ad
Compare
seems sane to me. LGTM. |
Not finished yet, spec file part needs to be added before merging |
ArtiomDivak
force-pushed
the
issue-397
branch
2 times, most recently
from
September 27, 2023 12:11
315a007
to
dccd791
Compare
.gcno files are needed to get full coverage. This PR will save those files in a ${datadir}/coverage so we can use them later on to get the coverage with .gcna files. Fixes:eclipse-bluechi#397 Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gcno files are needed to get full coverage.
This PR will save those files in a ${datadir}/coverage so we can use
them later on to get the coverage with .gcna files.
Fixes:#397
Signed-off-by: Artiom Divak adivak@redhat.com