Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save .gcno files after meson build #574

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

ArtiomDivak
Copy link
Contributor

.gcno files are needed to get full coverage.
This PR will save those files in a ${datadir}/coverage so we can use
them later on to get the coverage with .gcna files.

Fixes:#397
Signed-off-by: Artiom Divak adivak@redhat.com

copyGcno.sh Outdated Show resolved Hide resolved
copyGcno.sh Outdated Show resolved Hide resolved
copyGcno.sh Outdated Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
@ArtiomDivak ArtiomDivak force-pushed the issue-397 branch 3 times, most recently from ed44357 to 1983e17 Compare September 20, 2023 11:41
meson.build Outdated Show resolved Hide resolved
@ArtiomDivak ArtiomDivak force-pushed the issue-397 branch 2 times, most recently from 3919b5e to 8825de6 Compare September 20, 2023 12:39
build-scripts/install-coverage.sh Outdated Show resolved Hide resolved
test.sh Outdated Show resolved Hide resolved
@ArtiomDivak ArtiomDivak force-pushed the issue-397 branch 2 times, most recently from bf16f65 to 5d739ad Compare September 21, 2023 03:49
@dougsland
Copy link
Contributor

seems sane to me. LGTM.

@mwperina
Copy link
Member

seems sane to me. LGTM.

Not finished yet, spec file part needs to be added before merging

@ArtiomDivak ArtiomDivak force-pushed the issue-397 branch 2 times, most recently from 315a007 to dccd791 Compare September 27, 2023 12:11
.gcno files are needed to get full coverage.
This PR will save those files in a ${datadir}/coverage so we can use
them later on to get the coverage with .gcna files.

Fixes:eclipse-bluechi#397
Signed-off-by: Artiom Divak <adivak@redhat.com>
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 5cd0b2c into eclipse-bluechi:main Sep 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants