Improve integration tests stability #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mwperina
commented
Sep 27, 2023
mwperina
commented
- Add delay to wait_for_unit_state method
- Wait for daemon-reload to finish
mwperina
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
mwperina
force-pushed
the
import-tests-stability
branch
3 times, most recently
from
f810639
to
15e71d5
Compare
|
LGTM but let me know when you need a final review (in case you add more patches) |
mwperina
force-pushed
the
import-tests-stability
branch
9 times, most recently
from
c4351a2
to
edca594
Compare
|
DO NOT MERGE - it will require to remove unnecessary changes after merging: #581 |
Added `delay` option to wait_for_unit_state method to wait before checking status again to prevent unnecessary bombarding API with status checks. Signed-off-by: Martin Perina <mperina@redhat.com>
When installing a new service as a part of a test we need to make sure that daemon-reload finished and the new service is available. Signed-off-by: Martin Perina <mperina@redhat.com>
1. We don't need to check bluechi-controller or bluechi-agent service status at the beginning of each test, because we already check this status at the end of each container startup 2. We should be calling `wait_for_unit_state_to_be` instead of directly calling `systemctl is-active` to make sure that service will get to the required status (even though it may not be yet in the required status). Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
import-tests-stability
branch
from
edca594
to
0c494f8
Compare
Ready for review :-; |
mkemel
reviewed
Oct 2, 2023
mkemel
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.