-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename bluechi RPM to bluechi-controller #597
Conversation
+1 on the rename to -controller but I'm not sure on the meta package |
Isn't the meta package just for simplification and logically group packages? E.g. typing one command installs all packages? In that case it would be ok since its still possible to install each package individually, right? |
11d9af0
to
6d14b03
Compare
Wouldn't the metapackage be just bluechi, yum install bluechi Installs all packages? |
Sorry, I forgot to update PR description according to latest changes in the commit.
So by having bluechi-all we can solve the hiding problem and by bluechi-controller obsoleting bluechi we can solve the upgrade issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pypingou Is this a common pattern for fedora, to install all packages like this? Other examples? |
Why of course, there are modules! /j Indeed, things like this are usually implemented as package groups + [weak] dependencies. However, I do remember one similar package: |
Renames bluechi RPM to bluechi-controller, which better describes the content of the package. Signed-off-by: Martin Perina <mperina@redhat.com>
6d14b03
to
8be7d88
Compare
OK, removed metapackage |
LGTM |
Renames bluechi RPM to bluechi-controller, which better describes the
content of the package.
Signed-off-by: Martin Perina mperina@redhat.com