Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bluechi RPM to bluechi-controller #597

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Oct 9, 2023

Renames bluechi RPM to bluechi-controller, which better describes the
content of the package.

Signed-off-by: Martin Perina mperina@redhat.com

@pypingou
Copy link
Member

pypingou commented Oct 9, 2023

+1 on the rename to -controller but I'm not sure on the meta package

@engelmi
Copy link
Member

engelmi commented Oct 9, 2023

+1 on the rename to -controller but I'm not sure on the meta package

Isn't the meta package just for simplification and logically group packages? E.g. typing one command installs all packages? In that case it would be ok since its still possible to install each package individually, right?

@mwperina mwperina force-pushed the bluechi-metapackage branch from 11d9af0 to 6d14b03 Compare October 9, 2023 11:21
@rhatdan
Copy link
Contributor

rhatdan commented Oct 9, 2023

Wouldn't the metapackage be just bluechi,

yum install bluechi

Installs all packages?

@mwperina mwperina changed the title Introduce bluechi metapackage Introduce bluechi-all metapackage Oct 9, 2023
@mwperina
Copy link
Member Author

mwperina commented Oct 9, 2023

Wouldn't the metapackage be just bluechi,

yum install bluechi

Installs all packages?

Sorry, I forgot to update PR description according to latest changes in the commit.
Pierre raised the upgrade issue I've missed:

for one this is going to break upgrades where suddenly where you had bluechi you'll end up with the 3 sub-packages
and also, that simplicity "hides" a bit the fact that there are three parts

So by having bluechi-all we can solve the hiding problem and by bluechi-controller obsoleting bluechi we can solve the upgrade issue

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Contributor

rhatdan commented Oct 9, 2023

@pypingou Is this a common pattern for fedora, to install all packages like this? Other examples?

@pypingou
Copy link
Member

@pypingou Is this a common pattern for fedora, to install all packages like this? Other examples?

No I think the only approaching thing I've seen is the used of groups in comps.xml and then dnf install @group, but I don't know a single meta-package package like this.
Maybe @contyk would have one?

@contyk
Copy link

contyk commented Oct 10, 2023

Why of course, there are modules! /j

Indeed, things like this are usually implemented as package groups + [weak] dependencies. However, I do remember one similar package: zathura-plugins-all.

Renames bluechi RPM to bluechi-controller, which better describes the
content of the package.

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina mwperina force-pushed the bluechi-metapackage branch from 6d14b03 to 8be7d88 Compare October 10, 2023 12:08
@mwperina mwperina changed the title Introduce bluechi-all metapackage Rename bluechi RPM to bluechi-controller Oct 10, 2023
@mwperina
Copy link
Member Author

OK, removed metapackage

@rhatdan
Copy link
Contributor

rhatdan commented Oct 10, 2023

LGTM

@rhatdan rhatdan merged commit ce7e325 into eclipse-bluechi:main Oct 10, 2023
@mwperina mwperina deleted the bluechi-metapackage branch October 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants