Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case IDs to automate report of results #611

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Add test case IDs to automate report of results #611

merged 2 commits into from
Oct 19, 2023

Conversation

pbrilla-rh
Copy link
Contributor

Adding ID for each test case, so it is linked together during reporting increasing tracebility

@mwperina
Copy link
Member

We need to resolve how those UUIDs are created and synced with Polarion test case.
Anyway more detailed description in the commit message of those IDs and how they are going to be used would be nice

mwperina
mwperina requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into a single one and add some nice description about the change also to the commit message

tests/README.md Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
@pbrilla-rh pbrilla-rh force-pushed the add_ids branch 2 times, most recently from e194a0a to ffa2452 Compare October 19, 2023 12:01
mwperina
mwperina approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbrilla-rh
Add test case IDs to increase tracebility
5f2d9ac 
Each test case should have unique UUID to help with traceability of test runs.
With UUID for each test case, it is easier to follow trends in stability over time.

Signed-off-by: Pavol Brilla <pbrilla@redhat.com>
engelmi
engelmi approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only a small NIT.
Would probably be good to add a check for the ID to the CI so that newly added tests really have an ID assigned. But that can be done in a separate PR.

tests/README.md Outdated Show resolved Hide resolved
@pbrilla-rh @engelmi
Update tests/README.md
9f2a3e1 
thanks this makes sense

Co-authored-by: Michael Engel <engel.michael@hotmail.de>
Signed-off-by: Pavol Brilla <48551923+pbrilla-rh@users.noreply.github.com>
@engelmi engelmi merged commit 44ed7e6 into eclipse-bluechi:main Oct 19, 2023
11 checks passed
@pbrilla-rh pbrilla-rh deleted the add_ids branch October 19, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelmi engelmi engelmi approved these changes

@mwperina mwperina mwperina approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbrilla-rh @mwperina @engelmi