Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integration tests specific network setup #612

Conversation

mwperina
Copy link
Member

We were setting up specific network range for integration tests, but we
were not using it directly within any test. So we can remove that
specific network setup and rely on the default.

Signed-off-by: Martin Perina mperina@redhat.com

We were setting up specific network range for integration tests, but we
were not using it directly within any test. So we can remove that
specific network setup and rely on the default.

Signed-off-by: Martin Perina <mperina@redhat.com>
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 2306a3f into eclipse-bluechi:main Oct 19, 2023
11 checks passed
@mwperina mwperina deleted the remove-unneeded-network-setup-from-tests branch October 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants