Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent - Save ManagerAddress in context and use in ensure #625

Merged

Conversation

ygalblum
Copy link
Contributor

The value of ManagerAddress was being overridden upon connection failure

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM

src/agent/agent.c Show resolved Hide resolved
@ygalblum ygalblum force-pushed the agent-manager-address-precedence branch from 1c534c4 to 9245b7e Compare October 30, 2023 07:29
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The value of ManagerAddress was being overridden upon connection failure

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
@ygalblum ygalblum force-pushed the agent-manager-address-precedence branch from 9245b7e to bd5dfc6 Compare October 30, 2023 08:26
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 571d918 into eclipse-bluechi:main Oct 30, 2023
10 checks passed
@ygalblum ygalblum deleted the agent-manager-address-precedence branch October 30, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants