extended monitor API by adding and removing peers #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
add-peer-to-monitor
branch
from
0c1c364
to
d62da3a
Compare
engelmi
requested review from
alexlarsson,
mkemel and
rhatdan
as code owners
alexlarsson
reviewed
Nov 29, 2023
engelmi
force-pushed
the
add-peer-to-monitor
branch
from
d62da3a
to
c01ea2d
Compare
Relates to: eclipse-bluechi#187 Monitor signals are only sent to the creator of the monitor. The new Peer API enables to add and remove additional listener on the same monitor with its subscriptions. A user with sufficient priviledges to make methods calls to BlueChi's API can add and remove peers. The processes for the peers can be run by a different user with no access to BlueChi's API, but will still be able to receive events if added by a privileged process. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
add-peer-to-monitor
branch
from
c01ea2d
to
43643bf
Compare
alexlarsson
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #187
Monitor signals are only sent to the creator of the monitor. The new Peer API enables to add and remove additional listener on the same monitor with its subscriptions.
A user with sufficient priviledges to make methods calls to BlueChi's API can add and remove peers. The processes for the peers can be run by a different user with no access to BlueChi's API, but will still be able to receive events if added by a privileged process.