removed D-Bus method Shutdown #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: eclipse-bluechi#682 The D-Bus method Shutdown was added in the early days of the project and has never been used to this day. The use case of this method is also not clear. So in order to keep the API of BlueChi as lean as possible, lets remove the Shutdown method. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
remove-shutdown-dbus-method
branch
from
00e2cbf to
834d08a
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #682
The D-Bus method Shutdown was added in the early days of the project and has never been used to this day. The use case of this method is also not clear. So in order to keep the API of BlueChi as lean as possible, lets remove the Shutdown method.
Note: The
Shutdowninterface was actually never documented - so the chances of it being used are even smaller.