bluechictl: introduce Method and Command structures #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkemel
force-pushed
the
bluechictl-restructure
branch
4 times, most recently
from
62eab85
to
97c2945
Compare
mkemel
force-pushed
the
bluechictl-restructure
branch
from
97c2945
to
42d4305
Compare
engelmi
requested changes
Jan 5, 2024
ygalblum
reviewed
Jan 7, 2024
mkemel
force-pushed
the
bluechictl-restructure
branch
2 times, most recently
from
8fbf0e0
to
74220e4
Compare
ygalblum
reviewed
Jan 8, 2024
mkemel
force-pushed
the
bluechictl-restructure
branch
2 times, most recently
from
8adb741
to
83698a4
Compare
engelmi
approved these changes
Jan 8, 2024
|
LGTM |
mkemel
force-pushed
the
bluechictl-restructure
branch
3 times, most recently
from
530b345
to
dfb78de
Compare
This introduces a new way to define and handle command line interface focusing on simplicity of adding and handling new methods and new options for each method separately. Introducing two new structures: Method and Command, and a set of functions to manage them. client/main.c shows how to define and use these. Also, Command interface can handle separate help outputs for each method, which can be introduced later. Signed-off-by: Mark Kemel <mkemel@redhat.com>
mkemel
force-pushed
the
bluechictl-restructure
branch
from
dfb78de
to
ad7c8c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new way to define and handle command line interface focusing on simplicity of adding and handling new methods and new options for each method separately.
Introducing two new structures: Method and Command, and a set of functions to manage them. client/main.c shows how to define and use these.
Also, Command interface can handle separate help outputs for each method, which can be introduced later.
Solves #324