-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify unit and integration tests coverage report #711
Merged
engelmi
merged 2 commits into
eclipse-bluechi:main
from
mwperina:unit-and-intregation-tests-coverage
Jan 30, 2024
Merged
Unify unit and integration tests coverage report #711
engelmi
merged 2 commits into
eclipse-bluechi:main
from
mwperina:unit-and-intregation-tests-coverage
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mwperina
commented
Jan 18, 2024
- Add unit test code coverage to integration test coverage report
- Remove unit test covergae report from unit-tests workflow
mwperina
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
January 18, 2024 09:44
/cc @ArtiomDivak |
ArtiomDivak
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mwperina
force-pushed
the
unit-and-intregation-tests-coverage
branch
from
January 23, 2024 13:26
6305520
to
c0d4923
Compare
Unit tests are executed during RPM build phase, so we need to add .gcda files from unit test execution into bluechi-coverage package to be able to create unified unit and integration test coverage report as a part of integration test execution. Signed-off-by: Martin Perina <mperina@redhat.com>
Unit tests are executed as a part of RPM build. Also we run integration tests with code coverage report as a part if integration-tests workflow, so there is no need to run coverage report for unit tests in unit-tests workflow. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
unit-and-intregation-tests-coverage
branch
from
January 26, 2024 16:41
c0d4923
to
03874f0
Compare
engelmi
reviewed
Jan 29, 2024
engelmi
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.