Retrieve the version from script on publish #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a new |
mwperina
reviewed
Jan 23, 2024
The workflow variable github.ref_name contains the tag name, which is in the form of v*.*.*. In the rpm spec file, however, we expect the format *.*.*. Therefore, lets change the format in the github workflow by using the string returned from the version script, e.g. 0.8.0 Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
improve-publish-workflow
branch
from
0dc0bf5
to
df2be84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow variable github.ref_name contains the tag name, which is in the form of v*... In the rpm spec file, however, we expect the format ..*. Therefore, lets change the format in the github workflow by using the string returned from the version script, e.g. 0.8.0