Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup controller when start fails #731

Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Feb 6, 2024

Fixes: #730

When controller_start fails, the cleanup in controller_stop still needs to be executed to remove all initialized nodes.

Fixes: eclipse-bluechi#730

When controller_start fails, the cleanup in controller_stop still
needs to be executed to remove all initialized nodes.

Signed-off-by: Michael Engel <mengel@redhat.com>
Copy link
Contributor

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougsland dougsland merged commit 0c70696 into eclipse-bluechi:main Feb 7, 2024
18 checks passed
@dougsland
Copy link
Contributor

Not related to the patch.

        FAILED scripts/create_coverage_report.py::test_create_coverag_report - Exception: Error merging info files from each integration test: lcov: Need one of options -z, -c, -a, -e, -r, -l, --diff or --summary
        Use lcov --help to get usage information
        ============================== 1 failed in 2.86s ===============================
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

        stderr (7 lines)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        Traceback (most recent call last):
          File "/var/tmp/tmt/run-001/plans/tier0/tree/bluechi_test/test.py", line 202, in run
            exec(ctrl_container, node_container)
          File "/var/tmp/tmt/run-001/plans/tier0/tree/scripts/create_coverage_report.py", line 42, in exec
            raise Exception(f"Error merging info files from each integration test: {output}")
        Exception: Error merging info files from each integration test: lcov: Need one of options -z, -c, -a, -e, -r, -l, --diff or --summary
        Use lcov --help to get usage information

@engelmi
Copy link
Member Author

engelmi commented Feb 7, 2024

Not related to the patch.

        FAILED scripts/create_coverage_report.py::test_create_coverag_report - Exception: Error merging info files from each integration test: lcov: Need one of options -z, -c, -a, -e, -r, -l, --diff or --summary
        Use lcov --help to get usage information
        ============================== 1 failed in 2.86s ===============================
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

        stderr (7 lines)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        Traceback (most recent call last):
          File "/var/tmp/tmt/run-001/plans/tier0/tree/bluechi_test/test.py", line 202, in run
            exec(ctrl_container, node_container)
          File "/var/tmp/tmt/run-001/plans/tier0/tree/scripts/create_coverage_report.py", line 42, in exec
            raise Exception(f"Error merging info files from each integration test: {output}")
        Exception: Error merging info files from each integration test: lcov: Need one of options -z, -c, -a, -e, -r, -l, --diff or --summary
        Use lcov --help to get usage information

Yes, seems like a hiccup of GH: https://github.com/eclipse-bluechi/bluechi/actions/runs/7816388198/job/21321858579#step:9:3201

@engelmi engelmi deleted the fix-controller-nodes-assert branch February 28, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running a second instance of bluechi-controller generated "Aborted (core dumped)"
2 participants