Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various meson warnings #738

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

mwperina
Copy link
Member

  • Don't use string literals as value for boolean options
  • Rename build option man to with_man_pages
  • Use boolean type for with_coverage build option
  • Remove unneeded empty lines in selinux/meson.build

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Martin Perina <mperina@redhat.com>
1. Renames build option `man` to `with_man_pages`
2. Changes the type of the option from `combo` to `boolean`
3. Add documentation for this option to README.developer.md

Signed-off-by: Martin Perina <mperina@redhat.com>
Use boolean type instead of combo for `with_coverage` build option

Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
@engelmi engelmi merged commit 249e092 into eclipse-bluechi:main Feb 13, 2024
19 checks passed
@mwperina mwperina deleted the fix-meson-warnings branch February 13, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants