Test agent connect via ControllerAddress #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
from
08e478a to
1e88c8f
Compare
mwperina
requested changes
Feb 14, 2024
...s/tests/tier0/bluechi-agent-connect-via-manager-address/config/ManagerAddress=127.0.0.1.conf
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-agent-connect-via-manager-address/main.fmf
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
from
1e88c8f to
dae2e84
Compare
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
2 times, most recently
from
a8c9320 to
15a53f9
Compare
engelmi
requested changes
Feb 14, 2024
There was a problem hiding this comment.
This test doesn't really test that an agent can connect via the ControllerAddress option as it is suggested in the summary of main.fmf. It tests that it fails, but doesn't verify the reason.
I'd suggest setting up a bluechi-agent and bluechi-controller on the same machine/container and try to make this work. The ControllerAddress was intended to work with systemd sockets, so unix sockets, for example. You can have a look at how it is used in the getting started guide:
https://bluechi.readthedocs.io/en/latest/getting_started/securing_multi_node/#haproxy-as-a-reverse-proxy
tests/tests/tier0/bluechi-agent-connect-via-manager-address/config/Invalid-ManagerAddress.conf
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
3 times, most recently
from
83af363 to
10533ad
Compare
mwperina
requested changes
Feb 21, 2024
.../bluechi-agent-connect-via-manager-address/test_bluechi_agent_connect_via_manager_address.py
Outdated
Show resolved
Hide resolved
.../bluechi-agent-connect-via-manager-address/test_bluechi_agent_connect_via_manager_address.py
Outdated
Show resolved
Hide resolved
mwperina
changed the title
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
2 times, most recently
from
697aec7 to
5544fa9
Compare
mwperina
reviewed
Feb 21, 2024
...hi-agent-connect-via-controller-address/test_bluechi_agent_connect_via_controller_address.py
Outdated
Show resolved
Hide resolved
mwperina
reviewed
Feb 21, 2024
...hi-agent-connect-via-controller-address/test_bluechi_agent_connect_via_controller_address.py
Outdated
Show resolved
Hide resolved
mwperina
approved these changes
Feb 21, 2024
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
2 times, most recently
from
7980550 to
c4519b7
Compare
engelmi
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM
Small NIT. As soon as you update the branch we can merge @ArtiomDivak
...sts/tier0/bluechi-agent-connect-via-controller-address/config/Invalid-ControllerAddress.conf
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
from
c4519b7 to
4f39e65
Compare
mwperina
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
from
4f39e65 to
205dcd7
Compare
Added a test for agent to test if it connectes via ControllerAddress. This test will run an agent and controller. The agent configuration will be change to invalid ControllerAdress and then to valid one. The valid configuration will get an IP the the controller is listenning to and the invalid one will get an unlistened IP. Related: eclipse-bluechi#668 Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina
force-pushed
the
bluechi-agent-connect-via-manager-address
branch
from
205dcd7 to
bebca9a
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for agent to test if it connectes via ControllerAddress. This test will run an agent and change its configuration to use localhost instead of the real valid IP address in ControllerAddress and expect the agent to be failed because the controller is not listening on this IP.
Related: #668