Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load config from cli option as part of load complete config #744

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Feb 15, 2024

Relates to: #678

Moved loading the config file specified by CLI option to the function loading the complete config and updated unit tests accordingly. This way loading configuration from all sources is encapsulated in a single function.

Relates to: eclipse-bluechi#678

Moved loading the config file specified by CLI option to the function
loading the complete config and updated unit tests accordingly. This
way loading configuration from all sources is encapsulated in a
single function.

Signed-off-by: Michael Engel <mengel@redhat.com>
@coveralls
Copy link

Coverage Status

coverage: 66.109% (-0.04%) from 66.152%
when pulling 4d117e4 on engelmi:add-parse-config-unit-tests
into 01ccc68 on eclipse-bluechi:main.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelmi engelmi merged commit b717af6 into eclipse-bluechi:main Feb 15, 2024
19 of 20 checks passed
@engelmi engelmi deleted the add-parse-config-unit-tests branch February 28, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants