Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test metrics enable and then disable #755

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

mkemel
Copy link
Member

@mkemel mkemel commented Feb 21, 2024

Adds an integration test which checks that metrics are enabled and disabled correctly back-and-forth

Relates to #668

@mkemel mkemel force-pushed the tests branch 2 times, most recently from 43a6e97 to a8524ed Compare February 21, 2024 16:30
@coveralls
Copy link

coveralls commented Feb 21, 2024

Coverage Status

coverage: 74.043% (+0.6%) from 73.395%
when pulling 5aaf4cb on mkemel:tests
into a770b66 on eclipse-bluechi:main.

@mkemel mkemel marked this pull request as ready for review February 21, 2024 16:32
@engelmi
Copy link
Member

engelmi commented Feb 22, 2024

/packit rebuild-failed

Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 NITs, otherwise LGTM

Adds an integration test which checks that metrics are enabled and
disabled correctly back-and-forth

Signed-off-by: Mark Kemel <mkemel@redhat.com>
Signed-off-by: Mark Kemel <mkemel@redhat.com>
@mkemel mkemel merged commit 1ff9217 into eclipse-bluechi:main Feb 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants