Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new document describing the expected DBUS apis #78

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

alexlarsson
Copy link
Contributor

Signed-off-by: Alexander Larsson alexl@redhat.com

doc/dbus-interfaces.md Outdated Show resolved Hide resolved
doc/dbus-interfaces.md Outdated Show resolved Hide resolved
doc/dbus-interfaces.md Outdated Show resolved Hide resolved
doc/dbus-interfaces.md Outdated Show resolved Hide resolved
doc/dbus-interfaces.md Outdated Show resolved Hide resolved
sdunnagan
sdunnagan approved these changes Jan 25, 2023
doc/dbus-interfaces.md Outdated Show resolved Hide resolved
doc/dbus-interfaces.md Outdated Show resolved Hide resolved
@pypingou
Copy link
Member

The one question I have is: we say the main process is the orchestrator and the dbus API is centered around Manager. Are we ok with that or do we want to reconcile these two terms?

doc/dbus-interfaces.md Outdated Show resolved Hide resolved
* Register(in st name)

Before anything else can happen the node must call this method to
register with the orchastrator, giving its unique name. If this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
register with the orchastrator, giving its unique name. If this
register with the orchestrator, giving its unique name. If this


Before anything else can happen the node must call this method to
register with the orchastrator, giving its unique name. If this
succeeds, then the orchastrator will consider the node online and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
succeeds, then the orchastrator will consider the node online and
succeeds, then the orchestrator will consider the node online and

Signed-off-by: Alexander Larsson <alexl@redhat.com>
@alexlarsson alexlarsson merged commit 18d3980 into eclipse-bluechi:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants