-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test DaemonReload #818
Merged
engelmi
merged 1 commit into
eclipse-bluechi:main
from
ArtiomDivak:issue-668-daemond-reload
Mar 12, 2024
Merged
Test DaemonReload #818
engelmi
merged 1 commit into
eclipse-bluechi:main
from
ArtiomDivak:issue-668-daemond-reload
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel and
rhatdan
as code owners
March 10, 2024 09:42
ArtiomDivak
force-pushed
the
issue-668-daemond-reload
branch
4 times, most recently
from
March 10, 2024 09:53
e458dae
to
950a978
Compare
mwperina
requested changes
Mar 11, 2024
tests/tests/tier0/bluechi-daemon-reload/systemd/dont-perform-deamon-reload.service
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-daemon-reload/test_bluechi_deamon_reload.py
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
issue-668-daemond-reload
branch
4 times, most recently
from
March 11, 2024 11:55
2b90b0f
to
6e69ed6
Compare
mwperina
reviewed
Mar 11, 2024
ArtiomDivak
force-pushed
the
issue-668-daemond-reload
branch
2 times, most recently
from
March 11, 2024 13:08
90fc93a
to
522b6d6
Compare
engelmi
reviewed
Mar 11, 2024
tests/tests/tier0/bluechi-daemon-reload/test_bluechi_deamon_reload.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-daemon-reload/test_bluechi_deamon_reload.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-daemon-reload/test_bluechi_deamon_reload.py
Outdated
Show resolved
Hide resolved
tests/tests/tier0/bluechi-daemon-reload/test_bluechi_deamon_reload.py
Outdated
Show resolved
Hide resolved
ArtiomDivak
force-pushed
the
issue-668-daemond-reload
branch
from
March 11, 2024 14:03
522b6d6
to
31ade4b
Compare
10 tasks
ArtiomDivak
force-pushed
the
issue-668-daemond-reload
branch
from
March 11, 2024 14:50
31ade4b
to
cef0be6
Compare
mwperina
reviewed
Mar 11, 2024
mwperina
reviewed
Mar 11, 2024
mwperina
reviewed
Mar 11, 2024
ArtiomDivak
force-pushed
the
issue-668-daemond-reload
branch
2 times, most recently
from
March 12, 2024 07:43
be7a974
to
8938e33
Compare
This integration test tests the Daemond Reload by adding new service that won't start first. After changing the file and by using daemon reload the service will start and will be 'active' Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engelmi
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integration test tests the Daemond Reload by adding new service that won't start first. After changing the file and by using daemon reload the service will start and will be 'active'