Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script for duplicate test id and summary check #904

Merged
merged 1 commit into from
May 22, 2024

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented May 17, 2024

In order to avoid duplicate test IDs and/or summaries, a python script has been added and integrated into the CI to check for this. The check for duplicate IDs is only temporary till teemtee/tmt#2939 gets implemented (and released).

@engelmi
Copy link
Member Author

engelmi commented May 17, 2024

/cc @dracher

@engelmi engelmi force-pushed the add-test-id-duplicate-check branch from 5174b4c to 1973cb8 Compare May 17, 2024 13:52
@coveralls
Copy link

coveralls commented May 17, 2024

Coverage Status

coverage: 85.066%. remained the same
when pulling e969f53 on engelmi:add-test-id-duplicate-check
into fb45969 on eclipse-bluechi:main.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment about script placement, other than that it looks good

tests/tools/duplicate-check.py Outdated Show resolved Hide resolved
@engelmi engelmi force-pushed the add-test-id-duplicate-check branch from 1973cb8 to 6e5d15b Compare May 21, 2024 06:13
@engelmi engelmi force-pushed the add-test-id-duplicate-check branch from 6e5d15b to 41fc2d9 Compare May 21, 2024 07:26
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Copy link
Member

Hmm, we may need to install fmf module in https://github.com/eclipse-bluechi/bluechi/blob/main/.github/workflows/integration-tests.yml#L75

@engelmi engelmi force-pushed the add-test-id-duplicate-check branch 3 times, most recently from de3519c to da08e93 Compare May 21, 2024 08:34
In order to avoid duplicate test IDs and/or summaries, a
python script has been added and integrated into the CI
to check for this.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi force-pushed the add-test-id-duplicate-check branch from da08e93 to e969f53 Compare May 22, 2024 16:24
@engelmi engelmi merged commit 88afc8f into eclipse-bluechi:main May 22, 2024
21 checks passed
@engelmi engelmi deleted the add-test-id-duplicate-check branch June 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants