Display zoom icons only for time related charts

fixes #527 Signed-off-by: muddana-satish <satish.muddana@ericsson.com>
eclipse-cdt-cloud · Nov 10, 2021 · 93bec46 · 93bec46
1 parent 9694e6b
commit 93bec46
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/...xtensions/viewer-prototype/src/browser/trace-viewer/trace-viewer-toolbar-contribution.tsx b/...xtensions/viewer-prototype/src/browser/trace-viewer/trace-viewer-toolbar-contribution.tsx
@@ -45,21 +45,39 @@ export class TraceViewerToolbarContribution implements TabBarToolbarContribution
     registerCommands(registry: CommandRegistry): void {
         registry.registerCommand(
             TraceViewerToolbarCommands.ZOOM_IN, {
-            isVisible: (w: Widget) => w instanceof TraceViewerWidget,
+            isVisible: (w: Widget) => {
+                if (w instanceof TraceViewerWidget) {
+                    const traceWidget = w as TraceViewerWidget;
+                    return traceWidget.isTimeRelatedChartOpened();
+                }
+                return false;
+            },
             execute: () => {
                 signalManager().fireUpdateZoomSignal(true);
             }
         });
         registry.registerCommand(
             TraceViewerToolbarCommands.ZOOM_OUT, {
-            isVisible: (w: Widget) => w instanceof TraceViewerWidget,
+            isVisible: (w: Widget) => {
+                if (w instanceof TraceViewerWidget) {
+                    const traceWidget = w as TraceViewerWidget;
+                    return traceWidget.isTimeRelatedChartOpened();
+                }
+                return false;
+            },
             execute: () => {
                 signalManager().fireUpdateZoomSignal(false);
             }
         });
         registry.registerCommand(
             TraceViewerToolbarCommands.RESET, {
-            isVisible: (w: Widget) => w instanceof TraceViewerWidget,
+            isVisible: (w: Widget) => {
+                if (w instanceof TraceViewerWidget) {
+                    const traceWidget = w as TraceViewerWidget;
+                    return traceWidget.isTimeRelatedChartOpened();
+                }
+                return false;
+            },
             execute: () => {
                 signalManager().fireResetZoomSignal();
             }

diff --git a/theia-extensions/viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx b/theia-extensions/viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx
@@ -471,4 +471,9 @@ export class TraceViewerWidget extends ReactWidget {
             this.update();
         }
     }
+
+    isTimeRelatedChartOpened(): boolean {
+        const timeRelatedOutputs = this.outputDescriptors.filter(output => output.type === 'TIME_GRAPH' || output.type === 'TREE_TIME_XY');
+        return timeRelatedOutputs.length > 0;
+    }
 }