Handle conflicting experiments when opening

When opening a trace with the same name as another experiment, the experiment
that contains it will have a conflict on the server. The client should
retry posting it with a different name until it succeeds or another
error occurs.

The title of the trace viewer should also be updated to represent the
actual name of the experiment.

Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx

@@ -80,6 +80,7 @@ export class TraceViewerWidget extends ReactWidget {
         const experiment = await this.experimentManager.openExperiment(this.uri.name, traces);
         if (experiment) {
             this.openedExperiment = experiment;
+            this.title.label = 'Trace: ' + experiment.name;
         }
 
         this.update();

viewer-prototype/src/common/experiment-manager.ts

@@ -5,6 +5,7 @@ import { Query } from 'tsp-typescript-client/lib/models/query/query';
 import { injectable, inject } from 'inversify';
 import { OutputDescriptor } from 'tsp-typescript-client/lib/models/output-descriptor';
 import { Experiment } from 'tsp-typescript-client/lib/models/experiment';
+import { TspClientResponse } from 'tsp-typescript-client/lib/protocol/tsp-client-response';
 
 @injectable()
 export class ExperimentManager {
@@ -87,11 +88,33 @@ export class ExperimentManager {
             'traces': traceURIs
         }));
         const experiment = experimentResponse.getModel()
-        if (experiment && (experimentResponse.isOk() || experimentResponse.getStatusCode() === 409)) {
+        if (experiment && experimentResponse.isOk()) {
             this.addExperiment(experiment);
             this.experimentOpenedEmitter.fire(experiment);
             return experiment;
+        } else if (experiment && experimentResponse.getStatusCode() === 409) {
+            // Repost with a suffix as long as there are conflicts
+            let handleConflict = async function(tspClient: TspClient, tryNb: number): Promise<TspClientResponse<Experiment>> {
+                let suffix = '(' + tryNb + ')';
+                return await tspClient.createExperiment(new Query({
+                    'name': name + suffix,
+                    'traces': traceURIs
+                }))
+            }
+            let conflictResolutionResponse = experimentResponse;
+            let i = 1;
+            while (conflictResolutionResponse.getStatusCode() === 409) {
+                conflictResolutionResponse = await handleConflict(this.tspClient, i);
+                i++;
+            }
+            const experiment = conflictResolutionResponse.getModel()
+            if (experiment && conflictResolutionResponse.isOk()) {
+                this.addExperiment(experiment);
+                this.experimentOpenedEmitter.fire(experiment);
+                return experiment;
+            }
         }
+        // TODO Handle any other experiment open errors
         return undefined;
     }
 

viewer-prototype/src/common/trace-manager.ts

@@ -85,11 +85,12 @@ export class TraceManager {
             'uri': tracePath
         }));
         const trace = traceResponse.getModel()
-        if (trace && (traceResponse.isOk() || traceResponse.getStatusCode() === 409)) {
+        if (trace && traceResponse.isOk()) {
             this.addTrace(trace);
             this.traceOpenedEmitter.fire(trace);
             return trace;
         }
+        // TODO Handle trace open errors
         return undefined;
     }