Skip to content

Commit

Permalink
Clarify package info cleanup not related to keytar
Browse files Browse the repository at this point in the history
Since the convention is to put the comments that clarify the
installation commands above rather than next to the command, it looks
like the comment labels a section of possibly more than one command.
When the install and remove commands aren't separated by anything it
looks like both commands are part of setting up the keytar package.

For comparison, this is what it looked like before:

    # keytar
    && sudo apt-get install -y libsecret-1-dev \
    && sudo rm -rf /var/lib/apt/lists/*

Add comment between commands to clarify that they're unrelated.

Signed-off-by: Erica Bugden <erica.bugden@gmail.com>
  • Loading branch information
ebugden authored and bhufmann committed Sep 23, 2021
1 parent d0752f4 commit b5d4d74
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .gitpod.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ RUN sudo apt-get update \
&& sudo apt-get install -y libx11-dev libxkbfile-dev \
# keytar
&& sudo apt-get install -y libsecret-1-dev \
# Clear package info (to free space)
&& sudo rm -rf /var/lib/apt/lists/*

ENV NODE_VERSION="12.14.1"
Expand Down

0 comments on commit b5d4d74

Please sign in to comment.