Skip to content

Commit

Permalink
Do a 'yarn upgrade' before otherwise broken uplift
Browse files Browse the repository at this point in the history
This upgrade is necessary so the following Theia version uplift still
works with the electron yarn commands.

Cap the fontawesome-svg-core version to less than 1.3.0. Without this
change, the hereby upgrade leads to a broken yarn build. This is despite
requesting for a version that remains compatible with 1.2.17. So a yarn
upgrade without this adjustment lends the use of v1.3.0, which breaks the
build. Below [1] flags that breaking version as deprecated, and the
later versions are way more major uplifts (6.x.y).

[1]https://www.npmjs.com/package/@fortawesome/fontawesome-svg-core?activeTab=versions

Signed-off-by: Marco Miller <marco.miller@ericsson.com>
  • Loading branch information
marco-miller committed Jun 13, 2023
1 parent 45432b4 commit e44236a
Show file tree
Hide file tree
Showing 2 changed files with 3,392 additions and 3,173 deletions.
2 changes: 1 addition & 1 deletion packages/react-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"style"
],
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^1.2.17",
"@fortawesome/fontawesome-svg-core": "^1.2.17 <1.3.0",
"@fortawesome/free-solid-svg-icons": "^5.8.1",
"@fortawesome/react-fontawesome": "^0.1.4",
"@vscode/codicons": "^0.0.29",
Expand Down
Loading

0 comments on commit e44236a

Please sign in to comment.