Check time selection range for undefined value

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
eclipse-cdt-cloud · May 19, 2021 · f41237f · f41237f
1 parent 3006ce9
commit f41237f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 25 deletions.
diff --git a/packages/react-components/src/components/table-output-component.tsx b/packages/react-components/src/components/table-output-component.tsx
@@ -214,21 +214,23 @@ export class TableOutputComponent extends AbstractOutputComponent<TableOutputPro
         });
     }
 
-    private async handleTimeSelectionChange(range: TimelineChart.TimeGraphRange) {
-        const start = Math.trunc(this.props.range.getstart() + range.start);
-        if (this.lastIndex.timestamp === start) {
-            return;
-        }
-        const index = await this.fetchTableIndex(start);
-        if (index && this.gridApi) {
-            this.lastIndex = { timestamp: start, index: index };
-            this.gridApi.deselectAll();
-            this.gridApi.ensureIndexVisible(index);
-            const node = this.gridApi.getDisplayedRowAtIndex(index);
-            if (node.id) {
-                node.setSelected(true);
-            } else {
-                this.pendingIndex = index;
+    private async handleTimeSelectionChange(range?: TimelineChart.TimeGraphRange) {
+        if (range) {
+            const start = Math.trunc(this.props.range.getstart() + range.start);
+            if (this.lastIndex.timestamp === start) {
+                return;
+            }
+            const index = await this.fetchTableIndex(start);
+            if (index && this.gridApi) {
+                this.lastIndex = { timestamp: start, index: index };
+                this.gridApi.deselectAll();
+                this.gridApi.ensureIndexVisible(index);
+                const node = this.gridApi.getDisplayedRowAtIndex(index);
+                if (node.id) {
+                    node.setSelected(true);
+                } else {
+                    this.pendingIndex = index;
+                }
             }
         }
     }

diff --git a/packages/react-components/src/components/trace-context-component.tsx b/packages/react-components/src/components/trace-context-component.tsx
@@ -210,17 +210,19 @@ export class TraceContextComponent extends React.Component<TraceContextProps, Tr
         return Math.floor(totalWidth * this.COMPONENT_WIDTH_PROPORTION);
     }
 
-    private handleTimeSelectionChange(range: TimelineChart.TimeGraphRange) {
-        const t1 = Math.trunc(range.start + this.state.timeOffset);
-        const t2 = Math.trunc(range.end + this.state.timeOffset);
+    private handleTimeSelectionChange(range?: TimelineChart.TimeGraphRange) {
+        if (range) {
+            const t1 = Math.trunc(range.start + this.state.timeOffset);
+            const t2 = Math.trunc(range.end + this.state.timeOffset);
 
-        this.props.messageManager.addStatusMessage(this.TIME_SELECTION_STATUS_BAR_KEY, {
-            text: `T1: ${t1} T2: ${t2} Delta: ${t2 - t1}`,
-            category: Messages.MessageCategory.TRACE_CONTEXT
-        });
-        this.setState(prevState => ({
-            currentTimeSelection: new TimeRange(range.start, range.end, prevState.timeOffset)
-        }));
+            this.props.messageManager.addStatusMessage(this.TIME_SELECTION_STATUS_BAR_KEY, {
+                text: `T1: ${t1} T2: ${t2} Delta: ${t2 - t1}`,
+                category: Messages.MessageCategory.TRACE_CONTEXT
+            });
+            this.setState(prevState => ({
+                currentTimeSelection: new TimeRange(range.start, range.end, prevState.timeOffset)
+            }));
+        }
     }
 
     private handleViewRangeChange(viewRange: TimelineChart.TimeGraphRange) {