Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timegraph tree not rendered properly if back-end provides multiple columns #1149

Closed
bhufmann opened this issue Nov 18, 2024 · 1 comment · Fixed by #1152
Closed

timegraph tree not rendered properly if back-end provides multiple columns #1149

bhufmann opened this issue Nov 18, 2024 · 1 comment · Fixed by #1152

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Nov 18, 2024 •
edited
Loading

If a timegraph data provider provides columns, the tree with columns is not rendered properly. See below the output of a modified ThreadStatusDataProvider for LTTng Linux traces, that provides TID, PID, PTIP as separate column.

image

Note: Consider showing vertical grid-lines when showing columns

Note: That the header are not rendered either but this is out-of-scope of this issue, and it will be handled as a separate ticket (#1150).
@bhufmann bhufmann mentioned this issue Nov 18, 2024
Merged
@bhufmann
Copy link
Collaborator Author

Can be tested with change in Trace Compass: eclipse-tracecompass/org.eclipse.tracecompass#179

bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Nov 21, 2024
@bhufmann
Show column in TimegraphOutputComponent if back-end provides them
df0d9cc 
No header is drawed with the commit.

Fixes eclipse-cdt-cloud#1149

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Nov 21, 2024
@bhufmann
Show column in TimegraphOutputComponent if back-end provides them
7518339 
No header is drawn with the commit.

Fixes eclipse-cdt-cloud#1149

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@bhufmann bhufmann mentioned this issue Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show column in TimegraphOutputComponent if back-end provides them bhufmann/theia-trace-extension
1 participant
@bhufmann