-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate the use of BigInt or as string in the TSP #41
Comments
I forgot that there is an issue for this. A bit update to the current state. The JSON format itself supports BigInt. However, the By searching around I find the package json-bigint the most suitable, the package itself was inspired by the original Where do we go from here ? |
Maybe we can look into this: https://www.npmjs.com/package/timestamp-nano |
Use type 'bigint' for all variables that are timestamps or durations. Rename TimeRange.getstart() to getStart(). The minimum view range in XY chart navigation is set to 2 ns, to be able to zoom out of it and to always have at least one time axis tick fully visible. Fixes Issue eclipse-cdt-cloud#41 Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
Use type 'bigint' for all variables that are timestamps or durations. Rename TimeRange.getstart() to getStart(). The minimum view range in XY chart and toolbar button zooming is set to 2 ns, to be able to zoom out of it and to always have at least one time axis tick fully visible. Fixes Issue eclipse-cdt-cloud#41 Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
Use type 'bigint' for all variables that are timestamps or durations. Rename TimeRange.getstart() to getStart(). The minimum view range in XY chart and toolbar button zooming is set to 2 ns, to be able to zoom out of it and to always have at least one time axis tick fully visible. Fixes Issue eclipse-cdt-cloud#41 Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
Use type 'bigint' for all variables that are timestamps or durations. Rename TimeRange.getstart() to getStart(). The minimum view range in XY chart and toolbar button zooming is set to 2 ns, to be able to zoom out of it and to always have at least one time axis tick fully visible. Fixes Issue eclipse-cdt-cloud#41 Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
Use type 'bigint' for all variables that are timestamps or durations. Rename TimeRange.getstart() to getStart(). The minimum view range in XY chart and toolbar button zooming is set to 2 ns, to be able to zoom out of it and to always have at least one time axis tick fully visible. Fixes Issue #41 Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
Closing since resolved by PR #485. Utility of this fix: My understanding was not having BigInt precision on timestamps was making selection inaccurate. MatthewKhouzam: "we could not seek accurately without that patch. you would have 512 ns errors on your clicks" |
Use type 'bigint' for all variables that are timestamps or durations. Rename TimeRange.getstart() to getStart(). The minimum view range in XY chart and toolbar button zooming is set to 2 ns, to be able to zoom out of it and to always have at least one time axis tick fully visible. Fixes Issue eclipse-cdt-cloud#41 Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
The text was updated successfully, but these errors were encountered: