Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR about external analysis API in TSP #1004

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

bhufmann
Copy link
Collaborator

Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com

doc/adr/0011-tsp-analysis-api.md Outdated Show resolved Hide resolved
doc/adr/0011-tsp-analysis-api.md Outdated Show resolved Hide resolved
doc/adr/0011-tsp-analysis-api.md Show resolved Hide resolved
doc/adr/0011-tsp-analysis-api.md Outdated Show resolved Hide resolved
MatthewKhouzam
MatthewKhouzam previously approved these changes Aug 29, 2023
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find any typos. Also this makes a lot of sense, It will expand the functionality of theia's trace extension.

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhufmann bhufmann merged commit d18ca4e into eclipse-cdt-cloud:master Sep 1, 2023
2 checks passed
@bhufmann bhufmann deleted the adr-analysis-api branch September 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants