-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift theia dependencies from v1.37.2 to 1.40.1 #1009
Conversation
26671df
to
b03bd2d
Compare
There are some breaking changes that occurred in Theia that I noticed have not yet been reflected here. It would probably be good to go through past entries of the migration guide for other things that may have been missed.
becomes:
Mentioned here specifically about Electron, but it points to the complete list of re-exports: |
So far, the code looks good! |
I see the electron version was bumped, probably by the |
Thanks for pointers. I'll update the PR according to the migration guide. About the re-export comment I'll update the |
Perform a 'yarn upgrade' to keep the yarn.lock fully aligned. Base this uplifted-to Theia version on community [1]'s below. Fixed compilation error by making constructors of injectable classes public. Align to @postContruct changes of new inversify version [2]. Use Theia's re-export dependencies for inversify according to [3] Change electron-main location to ../src-gen/backend/ instead of ../src-gen/frontend due to breaking change described here [4] [1] https://theia-ide.org/releases/ [2] https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#inversify-60 [3] https://github.com/eclipse-theia/theia/blob/master/packages/core/README.md#re-exports [4] https://github.com/eclipse-theia/theia/blob/master/CHANGELOG.md#breaking_changes_1.39.0 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
b03bd2d
to
22877a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Bernd!
Uplift theia dependencies from v1.37.2 to 1.40.1
Perform a 'yarn upgrade' to keep the yarn.lock fully aligned.
Base this uplifted-to Theia version on community [1]'s below.
Fixed compilation error by making constructors of injectable classes
public.
Align to @postContruct changes of new inversify version [2]. Use Theia's
re-export dependencies for inversify according to [3]
Change electron-main location to ../src-gen/backend/ instead of
../src-gen/frontend due to breaking change described here [4]
[1] https://theia-ide.org/releases/
[2] https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#inversify-60
[3] https://github.com/eclipse-theia/theia/blob/master/packages/core/README.md#re-exports
[4] https://github.com/eclipse-theia/theia/blob/master/CHANGELOG.md#breaking_changes_1.39.0