Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift theia dependencies from v1.37.2 to 1.40.1 #1009

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

bhufmann
Copy link
Collaborator

@bhufmann bhufmann commented Sep 7, 2023

Uplift theia dependencies from v1.37.2 to 1.40.1

Perform a 'yarn upgrade' to keep the yarn.lock fully aligned.

Base this uplifted-to Theia version on community [1]'s below.

Fixed compilation error by making constructors of injectable classes
public.

Align to @postContruct changes of new inversify version [2]. Use Theia's
re-export dependencies for inversify according to [3]

Change electron-main location to ../src-gen/backend/ instead of
../src-gen/frontend due to breaking change described here [4]

[1] https://theia-ide.org/releases/
[2] https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#inversify-60
[3] https://github.com/eclipse-theia/theia/blob/master/packages/core/README.md#re-exports
[4] https://github.com/eclipse-theia/theia/blob/master/CHANGELOG.md#breaking_changes_1.39.0

@bhufmann bhufmann force-pushed the theia-upgrade branch 2 times, most recently from 26671df to b03bd2d Compare September 7, 2023 20:42
@marcdumais-work
Copy link
Contributor

There are some breaking changes that occurred in Theia that I noticed have not yet been reflected here. It would probably be good to go through past entries of the migration guide for other things that may have been missed.

  1. I think it would be good to use Theia re-exports whenever possible. One example is inversify:

import { inject, injectable } from 'inversify';

becomes:

import { inject, injectable } from '@theia/core/shared/inversify';

  1. (at some point) same as 1, use Theia re-exports in general - there may be other similar cases

Mentioned here specifically about Electron, but it points to the complete list of re-exports:
https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#electron-update

@marcdumais-work
Copy link
Contributor

So far, the code looks good!

@marcdumais-work
Copy link
Contributor

I see the electron version was bumped, probably by the yarn upgrade. It would be good to update the version in electron-builder.yml, to match. (23.3.13)

@bhufmann
Copy link
Collaborator Author

bhufmann commented Sep 8, 2023

There are some breaking changes that occurred in Theia that I noticed have not yet been reflected here. It would probably be good to go through past entries of the migration guide for other things that may have been missed.

1. I think it would be good to use Theia re-exports whenever possible. One example is `inversify`:

import { inject, injectable } from 'inversify';

becomes:

import { inject, injectable } from '@theia/core/shared/inversify';

2. (at some point) same as 1, use Theia re-exports in general - there may be other similar cases

Mentioned here specifically about Electron, but it points to the complete list of re-exports: https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#electron-update

Thanks for pointers. I'll update the PR according to the migration guide.

About the re-export comment I'll update the inversify dependency only in this PR, since there is also a new version. The others we can handle in a separate dedicated PR.

Perform a 'yarn upgrade' to keep the yarn.lock fully aligned.

Base this uplifted-to Theia version on community [1]'s below.

Fixed compilation error by making constructors of injectable classes
public.

Align to @postContruct changes of new inversify version [2]. Use Theia's
re-export dependencies for inversify according to [3]

Change electron-main location to ../src-gen/backend/ instead of
../src-gen/frontend due to breaking change described here [4]

[1] https://theia-ide.org/releases/
[2] https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#inversify-60
[3] https://github.com/eclipse-theia/theia/blob/master/packages/core/README.md#re-exports
[4] https://github.com/eclipse-theia/theia/blob/master/CHANGELOG.md#breaking_changes_1.39.0

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Bernd!

@bhufmann bhufmann merged commit 0552168 into master Sep 8, 2023
2 checks passed
@bhufmann bhufmann deleted the theia-upgrade branch September 8, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants