Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prototype of React Component displaying configurations source types #1031

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hoangphamEclipse
Copy link
Contributor

@hoangphamEclipse hoangphamEclipse commented Oct 11, 2023

ADR-0011 introduces the API for managing global configurations. Thus, the Trace Extension needs an interface to expose this API to users. This PR is a tracker for a series of commits that will add a new UI (as a React Component) for this feature.

@hoangphamEclipse
Copy link
Contributor Author

First prototype is pushed as the very first commit of the series.

The purpose of this commit is to start creating this UI for the trace extension as a React Component. It provides a skeleton for the component so that it can be further extended in future commits:

[1] Added TraceConfigurationManager to handle calls to the TSPClient that relates to trace configuration.

[2] Introduce a prototype of the UI as the
TraceConfigurationsDialogComponent. This is the main component of the UI that handles the display logic for other sub-components, such as [3].

[3] Added TraceConfigurationSourceTypeListComponent to list the available configuration source types from the server.

To test, open a trace and hover the mouse over the toolbar of the Available Views widget. There should be an icon that appears. Click on the icon to open the trace configuration dialog. In this prototype, the dialog should only display the configuration source types.

@hoangphamEclipse hoangphamEclipse force-pushed the configuration-ui branch 2 times, most recently from b903ecf to 4965db5 Compare October 11, 2023 21:38
ADR-0011 introduces the API for managing global configurations. Thus, the
Trace Extension needs an interface to expose this API to users.

The purpose of this commit is to start creating this UI for the trace
extension as a React Component. It provides a skeleton for the component
so that it can be further extended in future commits:

[1] Added TraceConfigurationManager to handle calls to the TSPClient that
relates to trace configuration.

[2] Introduce a prototype of the UI as the
TraceConfigurationsDialogComponent. This is the main component of the UI
that handles the display logic for other sub-components, such as [3].

[3] Added TraceConfigurationListComponent to list the available
configuration source types and their instances from the server.

To test, open a trace and hover the mouse over the toolbar of the
Available Views widget. There should be an icon that appears. Click on the
icon to open the trace configuration dialog. In this prototype, the dialog
should only display the configuration source types.

Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
This commit adds the TraceConfigurationManager to handle calls to the
trace server to manage configurations in the configuration UI.

Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
This commit add 2 new components to the configuration UI: A component used to add new configurations and another one to view the details of existing configurations. Existing components are also updated to integrate the new components.

Signed-off-by: Hoang Thuan Pham <hoang.pham@calian.ca>
@bhufmann bhufmann marked this pull request as draft April 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant