README: Add cdt cloud demo link #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops need to fix the commit signoff... |
Signed-off-by: Erica Bugden <ebugden@efficios.com>
ebugden
force-pushed
the
add-cdt-cloud-demo-to-readme
branch
from
2587152 to
0c2c552
Compare
|
Signoff fixed! I also just signed the contributor license agreement (screenshot below) with my efficios address so the test should pass now. I couldn't see how to re-run the check manually.
|
|
Just confirming that according to the ECA Validator I now do have a valid ECA signed (green square in screenshot below). The test didn't pass at time of submission because I hadn't yet signed.
|
MatthewKhouzam
approved these changes
Jan 15, 2024
|
Thank you for the review! 🌻 Let me know if there are other blockers to merging that need my input. Typically I would assume a rebase, but I'm assuming that is not needed for this small doc change. |
bhufmann
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MatthewKhouzam recently added a video that shows how to try the trace viewer via the CDT cloud live demo. I thought it could be relevant to add this information to the repo readme as well.
Phrasing and content edits welcome!