[ci] add infrastructure for automated releases/publish to npm (latest) #1056
Conversation
marcdumais-work
force-pushed
the
ci-publish-infra
branch
2 times, most recently
from
ec4148f to
50a37b8
Compare
| # - repo:status, repo_deployment, public_repo, read:org | ||
| # See here for more details: | ||
| # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow | ||
| token: ${{ secrets.GH_COMMITTER_TOKEN }} |
There was a problem hiding this comment.
I added that secret/token
| @@ -0,0 +1,8 @@ | |||
| tag: v0.0.0 | |||
There was a problem hiding this comment.
I created and pushed that tag, on commit 412b849 - Trace viewer prototype application (the second commit in this repo, right after "Initial commit"). This way, the first generated release notes will go back to the start of the repo's history (we can edit them after as needed)
There was a problem hiding this comment.
There is already a 0.1.0 release that was manually pushed to npm and a tag in the repo. Shouldn't you base the new release on the 0.1.0 tag instead?
There was a problem hiding this comment.
We could, but then the auto-generated release notes would start at v0.1.0. The plan is, after the next release, I will take the release notes and move those relevant to v0.1.0 into a manually-created GitHub release (from that tag). I did similar for time-line chart: https://github.com/eclipse-cdt-cloud/timeline-chart/releases
There was a problem hiding this comment.
timeline-chart: original release notes / GH release, that I manually massaged after release:
eclipse-cdt-cloud/timeline-chart#274 (comment)
There was a problem hiding this comment.
Right. Forgot about it. Makes sense.
There was a problem hiding this comment.
BTW, I'm not sure I was totally clear - the discussed tag (v0.0.0) will only affect the starting point for the auto-generated release notes, when we proceed with the first release, in another PR. This PR here will not result in a release, just setting the stage.
marcdumais-work
force-pushed
the
ci-publish-infra
branch
from
50a37b8 to
d68a2c6
Compare
|
Is it still a draft or ready for review? |
marcdumais-work
force-pushed
the
ci-publish-infra
branch
2 times, most recently
from
7378429 to
c613bb6
Compare
marcdumais-work
changed the title
Yes, I think so. I will transition it out of "draft". |
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
ci-publish-infra
branch
from
c613bb6 to
7048c9e
Compare
I'm going to review it. It looks good so far. |
|
Thanks for the review! |
This PR adds infrastructure to create GitHub releases (including auto-generated release notes) and publish
latestnpm packages, as part of the CI of this repository. See updated root README for instructions about how to trigger a release.Note: it's expected that the "GitHub release" job will fail at this point.