Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filter table tree for Available Views view implementation #1128

Merged

Conversation

bhufmann
Copy link
Collaborator

@bhufmann bhufmann commented Oct 10, 2024

  • Use FilterTree
  • Add tooltips to TreeNode and TableCell
  • Enable sorting and filter
  • Description of view is part of the tooltip instead of being printed below view name

fixes #1113

vscode-new-available-view2

Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com

@marcdumais-work marcdumais-work force-pushed the new_available_views_view branch from bdcb224 to 7c98af8 Compare October 11, 2024 12:45
@bhufmann bhufmann force-pushed the new_available_views_view branch 2 times, most recently from 59c563a to 637905f Compare October 11, 2024 19:09
if (this.state.treeNodes) {
return (
<div className="scrollable avail-views-table">
<FilterTree
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this into AvailableViewComponent? Then the Overview menu item to select the xy output would have it as well.

Copy link
Contributor

@PatrickTasse PatrickTasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now matter how wide the Available Views panel is resized, its scrollable content is just a little bit wider than the available width, so a horizontal scrollbar appears unnecessarily with a very small scrollable range. There might be some margin width unnaccounted for somewhere.

- Use FilterTree
- Add tooltips to TreeNode and TableCell
- Enable sorting and filter

fixes eclipse-cdt-cloud#1113

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@bhufmann bhufmann force-pushed the new_available_views_view branch from 637905f to e21c98d Compare October 24, 2024 19:24
@bhufmann
Copy link
Collaborator Author

Now matter how wide the Available Views panel is resized, its scrollable content is just a little bit wider than the available width, so a horizontal scrollbar appears unnecessarily with a very small scrollable range. There might be some margin width unnaccounted for somewhere.

This should be fixed in the updated version

@bhufmann bhufmann merged commit 0ae1fd4 into eclipse-cdt-cloud:master Nov 1, 2024
7 checks passed
@bhufmann bhufmann deleted the new_available_views_view branch November 1, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

req: Add searchable View List/Trace List
2 participants