Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docker example application #1163

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Dec 13, 2024

What it does

Fixes #1151

This PR removes the Docker example application and related files/mentions from this repository.
It has moved to repo:
https://github.com/eclipse-cdt-cloud/trace-viewer-examples

How to test

Confirm that the removal has not broken the CI and that no mentions/references to the locally hosted docker example were missed.

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Fixes #1151

It has moved to repo:
https://github.com/eclipse-cdt-cloud/trace-viewer-examples

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the clean-up!

@marcdumais-work marcdumais-work merged commit b667878 into master Dec 13, 2024
6 checks passed
@marcdumais-work
Copy link
Contributor Author

Thanks for the review!

@marcdumais-work marcdumais-work deleted the remove-docker-app branch December 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove docker example, that has been migrated to repo "trace-viewer-examples"
2 participants