Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for NodeJS version #807

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Rodrigoplp-work
Copy link
Contributor

Update requirements for NodeJS versions to allow the use of v16.

Fixes #806.

Signed-off-by: Rodrigo Pinto rodrigo.pinto@calian.ca

@Rodrigoplp-work Rodrigoplp-work marked this pull request as draft August 16, 2022 20:03
Update requirements for NodeJS versions to allow the use of v16.

Fixes eclipse-cdt-cloud#806.

Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
@Rodrigoplp-work Rodrigoplp-work marked this pull request as ready for review August 16, 2022 20:16
Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@bhufmann bhufmann requested a review from marco-miller August 17, 2022 20:40
@marco-miller marco-miller self-assigned this Aug 17, 2022
Copy link
Contributor

@marco-miller marco-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too; tested locally using both v14 and v16 current latest LTS versions.

@marco-miller marco-miller removed their assignment Aug 18, 2022
@Rodrigoplp-work Rodrigoplp-work merged commit aeb1173 into eclipse-cdt-cloud:master Aug 18, 2022
@Rodrigoplp-work Rodrigoplp-work deleted the node16 branch August 23, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update requirements for NodeJS versions to match those of Theia, specifically v.16
3 participants