Marker navigation #239
Merged
Marker navigation #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 10, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 10, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 10, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 10, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com>
bhufmann
approved these changes
Feb 13, 2023
PatrickTasse
requested changes
Feb 13, 2023
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
It's asking for a newline at EOF
Makes sense. My commit doesn't need to be merged. |
Implements functionality to navigate through markers using "," & ".". Renames the new class with appropriate name: TimeGraphMarkersChartCursor. Removes duplicate code by using class inheritance. Fixes bug where canvas loses focus when selection is out of world range. Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work
force-pushed
the
marker-navigation
branch
from
8d7ea83 to
3a76074
Compare
|
New line added and commits squashed. |
bhufmann
approved these changes
Feb 13, 2023
PatrickTasse
approved these changes
Feb 17, 2023
This was referenced Feb 17, 2023
Closed
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com>
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Adds the ability to select rows in the markers-chart layer. Improves the logic of selected row feature. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com> fixed hard-coded css
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Adds the ability to select rows in the markers-chart layer. Improves the logic of selected row feature. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com> fixed hard-coded css
williamsyang-work
added a commit
to williamsyang-work/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Adds the ability to select rows in the markers-chart layer. Improves the logic of selected row feature. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com> fixed hard-coded css
hriday-panchasara
pushed a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Feb 21, 2023
Implements functionality to navigate through markers using "," & ".". Includes new "TimeGraphMarkersChartCursors" layer and uses it with the chart layer in the Markers Container. Adds the ability to select rows in the markers-chart layer. Improves the logic of selected row feature. Depends on: eclipse-cdt-cloud/timeline-chart#239 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com> Signed-Off-By: Will Yang <william.yang@ericsson.com> fixed hard-coded css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements functionality to navigate through markers by using "," and ".".
Fixes the TODO's listed in PR #237. Uses class inheritance to remove duplicate code. Uses different algorithm for computing next/previous state, since marker states don't always come in a time-sorted array.
Signed-off-by: Will Yang william.yang@ericsson.com