Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lerna] upgrade to recent version #264

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[lerna] upgrade to recent version #264

merged 1 commit into from
Sep 21, 2023

Conversation

marcdumais-work
Copy link
Contributor

Description

Upgraded lerna from v4.x to 7.x, getting rid of several big security vulnerabilities, that were present in the older version.

How to test?

Repo build should be successful and the example application should run as expected.

The publishing "script" entries for this repo are identical to the ones used in theia-trace-extension, and so i have not gone through the process of testing publishing using a local registry. I can do it, if deemed necessary.

yarn audit

Before this PR (master):
image

After:
image

Fixes #262

Updated lerna from v4.x to 7.x, getting rid of several big security
vulnerabilities, that were present in the older version.

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Theia... not VSCode.

@bhufmann bhufmann self-requested a review September 21, 2023 14:15
Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@marcdumais-work marcdumais-work merged commit 5662085 into master Sep 21, 2023
2 checks passed
@marcdumais-work marcdumais-work deleted the upgrade-lerna branch September 21, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants