Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom analysis related APIs #119

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

bhufmann
Copy link
Collaborator

@bhufmann bhufmann commented Nov 5, 2024

  • Support parentId and creation configuration in output descriptors
  • Add ProviderType enum for the type in OutputDescriptors
  • Add APIs to support configurable output (data provider)
    • Add ConfigurationQuery and OutputConfigurationQuery
    • Add utility methods in query-helper.ts to create such query instances
    • Add configuration service per output (data provider)
      This addition enables clients to create derived data providers from
      an existing data provider.
    • Add unit tests

Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@@ -0,0 +1,25 @@
{
"parentId": "org.eclipse.tracecompass.incubator.inandout.core.analysis.inAndOutdataProviderFactory",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be (D)ata?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -105,4 +105,50 @@ describe('Query helper tests', () => {

expect(test).toEqual(array);
});

it('Should create a configutation query', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

expect(test).toEqual(query);
});

it('Should create a output configutation query', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

/**
* Constructor
* @param name Name of the configuration
* @param parameters Object use to send parameters to the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* @param name Name of the configuration
* @param description Optional description of the configuraiton
* @param typeId The ID of the configuration source type
* @param parameters Object use to send parameters to the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


const response = await client.createDerivedOutput(
'd280b5ab-b0ff-38cf-b3e1-d33a0d56d1a3',
'org.eclipse.tracecompass.incubator.inandout.core.analysis.inAndOutdataProviderFactory',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(D)ata?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- Add ConfigurationQuery and OutputConfigurationQuery
- Add utility methods in query-helper.ts to create such query instances
- Add configuration service per output (data provider)
  This addition enables clients to create derived data providers from
  an existing data provider.
- Add unit tests

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@bhufmann bhufmann merged commit 7fdc65b into eclipse-cdt-cloud:master Nov 6, 2024
5 checks passed
@bhufmann bhufmann deleted the custom_outputs branch November 6, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants