New blog post about configuring git repositories #24

xbaran4 · 2022-02-16T13:18:06Z

Blog post about configuring git repositories. Jira issue https://issues.redhat.com/browse/RHDEVDOCS-3501

ibuziuk

looks like a few .idea files have been added

max-cx

Please review my suggested changes.
If you don't feel like any suggested change is correct or warranted, please respond in the comment thread so that we can discuss and review it. I'll be happy to suggest an alternative.

_posts/2022-XX-XX-configuring-git-repositories.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>

_posts/2022-XX-XX-configuring-git-repositories.adoc

Co-authored-by: Max Leonov <mleonov@redhat.com>

Signed-off-by: Pavol Baran <pbaran@redhat.com>

ibuziuk · 2022-03-16T12:57:39Z

@max-cx the suggestions have been applied. Do you plan to approve the PR?

max-cx

LGMT

ibuziuk · 2022-03-16T13:57:08Z

_posts/2022-XX-XX-configuring-git-repositories.adoc

@@ -0,0 +1,267 @@
+---


@xbaran4 looks like you can now put the date for publication

Is the date somewhere specified or is it up to me? The schedule in #19 is oudated.

I think you can pick the date and update the issue description

_posts/2022-XX-XX-configuring-git-repositories.adoc

max-cx · 2022-03-22T10:44:36Z

_posts/2022-XX-XX-configuring-git-repositories.adoc

+
+$ cat public.pub | sed 's/-----BEGIN PUBLIC KEY-----//g' | sed 's/-----END PUBLIC KEY-----//g' | tr -d '\n' > public-stripped.pub
+
+$ cat privatepkcs8.pem | sed 's/-----BEGIN PRIVATE KEY-----//g' |  sed 's/-----END PRIVATE KEY-----//g' | tr -d '\n' > privatepkcs8-stripped.pem


@xbaran4, is there a step where this file gets encoded to Base64? I can't find it. It looks like the procedure for applying the secret requires it encoded to Base64.

No it's not here. But it's not only the private key. The consumer key also needs to be base64 encoded (even though it's created like this openssl rand -base64 24). And I noticed something that's not in our documentation (https://www.eclipse.org/che/docs/che-7/administration-guide/configuring-authorization/#proc_configuring-bitbucket-server-oauth1_che), but is in our testing script. The bitbucket secret also needs to contain the shared secret. I am going to update it.

@xbaran4, by "something that's not in our documentation" do you mean https://github.com/skabashnyuk/gitsrv/blob/main/bitbucket/4_setupche.sh ?

@xbaran4, can I add base64 here then?

Suggested change

$ cat privatepkcs8.pem | sed 's/-----BEGIN PRIVATE KEY-----//g' | sed 's/-----END PRIVATE KEY-----//g' | tr -d '\n' > privatepkcs8-stripped.pem

$ cat privatepkcs8.pem | sed 's/-----BEGIN PRIVATE KEY-----//g' | sed 's/-----END PRIVATE KEY-----//g' | tr -d '\n' | base64 > privatepkcs8-stripped.pem

max-cx · 2022-03-23T15:03:27Z

_posts/2022-XX-XX-configuring-git-repositories.adoc

+
+==== Admin side
+
+After you've created the reference on the Git SCM, your {prod-short} administrator will create the following Kubernetes secret.


@xbaran4, let's say I am a Che user, and I have my own private fork of our team's private project repository because I do my work in my fork. If I set up, let's say a GitHub OAuth App, and the Che admin applies a Secret for it. Will this Secret enable my colleagues to access my private (my fork) repository with whatever (write-repo) permissions that I specified when setting up my GitHub OAuth App?

You need to go through the oauth flow to get an access token (which is then used to read/write etc). This access token is created for your Che user in his k8s namespace. If your colleague wanted his own access token, he would need to go through the oauth flow as well. Which means he would need to login to GitHub with your GitHub credentials.

Co-authored-by: Max Leonov <mleonov@redhat.com>

Signed-off-by: Pavol Baran <pbaran@redhat.com>

dkwon17 · 2022-03-28T14:12:22Z

_posts/2022-XX-XX-configuring-git-repositories.adoc

+
+Before you can access a private Git repository, some actions are required from you as a non-privileged user and from your {prod-short} administrator. Those actions are required for configuring the OAuth authorization so that {prod-short} can act on behalf of the user account on the Git SCM server. GitHub and GitLab use OAuth2, whereas Bitbucket uses OAuth1.
+
+==== User side


Hello, according to the docs and this comment: eclipse-che/che#21298 (comment) this should be a task meant to be performed by the admin.

Could we remove this User side section since the oauth app creation, retrieving client ID and client secret should be also done by an admin?

good catch 👍
OAuth config is expected to be admin SOP

_posts/2022-XX-XX-configuring-git-repositories.adoc

Co-authored-by: David Kwon <dakwon@redhat.com>

ibuziuk · 2024-05-07T13:32:47Z

Closing as outdated

feat: new blog post about configuring git repositories

c0ee584

xbaran4 force-pushed the configuring_git_repositories branch from c8dba8f to c0ee584 Compare February 16, 2022 13:22

ibuziuk reviewed Feb 16, 2022

View reviewed changes

max-cx requested changes Feb 25, 2022

View reviewed changes

xbaran4 and others added 2 commits March 1, 2022 07:25

Apply suggestions from code review

54a55fb

Co-authored-by: Max Leonov <mleonov@redhat.com>

Applying major suggestions from code review

97f4949

Co-authored-by: Max Leonov <mleonov@redhat.com>

max-cx reviewed Mar 2, 2022

View reviewed changes

_posts/2022-XX-XX-configuring-git-repositories.adoc Outdated Show resolved Hide resolved

xbaran4 and others added 2 commits March 2, 2022 10:18

Applying final suggestions to wording

8b8954c

Co-authored-by: Max Leonov <mleonov@redhat.com>

fix: removing .idea files

ef82f17

Signed-off-by: Pavol Baran <pbaran@redhat.com>

xbaran4 marked this pull request as ready for review March 7, 2022 10:10

max-cx approved these changes Mar 16, 2022

View reviewed changes

ibuziuk reviewed Mar 16, 2022

View reviewed changes

nickboldt mentioned this pull request Mar 16, 2022

DevWorkspace articles publishing planning #19

Closed

max-cx reviewed Mar 21, 2022

View reviewed changes

_posts/2022-XX-XX-configuring-git-repositories.adoc Outdated Show resolved Hide resolved

max-cx reviewed Mar 22, 2022

View reviewed changes

max-cx reviewed Mar 23, 2022

View reviewed changes

This was referenced Mar 23, 2022

procedures: accessing private Git repos eclipse-che/che-docs#2242

Closed

User guide - Git credentials and Git settings eclipse-che/che#21298

Closed

xbaran4 and others added 2 commits March 28, 2022 09:51

fix: filename typo

472aa02

Co-authored-by: Max Leonov <mleonov@redhat.com>

fix: generalizing url and added shared secret in bitbucket secret

95b152e

Signed-off-by: Pavol Baran <pbaran@redhat.com>

dkwon17 requested changes Mar 28, 2022

View reviewed changes

dkwon17 reviewed Mar 29, 2022

View reviewed changes

_posts/2022-XX-XX-configuring-git-repositories.adoc Outdated Show resolved Hide resolved

fix: correcting authorize URL

03470ad

Co-authored-by: David Kwon <dakwon@redhat.com>

ibuziuk closed this May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New blog post about configuring git repositories #24

New blog post about configuring git repositories #24

xbaran4 commented Feb 16, 2022

ibuziuk left a comment

max-cx left a comment

ibuziuk commented Mar 16, 2022

max-cx left a comment

ibuziuk Mar 16, 2022

xbaran4 Mar 16, 2022

ibuziuk Mar 21, 2022

max-cx Mar 22, 2022 •

edited

Loading

xbaran4 Mar 28, 2022

max-cx Mar 30, 2022

max-cx Mar 31, 2022

max-cx Mar 23, 2022 •

edited

Loading

xbaran4 Mar 28, 2022

dkwon17 Mar 28, 2022 •

edited

Loading

ibuziuk Mar 28, 2022

ibuziuk commented May 7, 2024


		$ cat public.pub \| sed 's/-----BEGIN PUBLIC KEY-----//g' \| sed 's/-----END PUBLIC KEY-----//g' \| tr -d '\n' > public-stripped.pub

		$ cat privatepkcs8.pem \| sed 's/-----BEGIN PRIVATE KEY-----//g' \| sed 's/-----END PRIVATE KEY-----//g' \| tr -d '\n' > privatepkcs8-stripped.pem


		==== Admin side

		After you've created the reference on the Git SCM, your {prod-short} administrator will create the following Kubernetes secret.


		Before you can access a private Git repository, some actions are required from you as a non-privileged user and from your {prod-short} administrator. Those actions are required for configuring the OAuth authorization so that {prod-short} can act on behalf of the user account on the Git SCM server. GitHub and GitLab use OAuth2, whereas Bitbucket uses OAuth1.

		==== User side

New blog post about configuring git repositories #24

New blog post about configuring git repositories #24

Conversation

xbaran4 commented Feb 16, 2022

ibuziuk left a comment

Choose a reason for hiding this comment

max-cx left a comment

Choose a reason for hiding this comment

ibuziuk commented Mar 16, 2022

max-cx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

max-cx Mar 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

max-cx Mar 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dkwon17 Mar 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ibuziuk commented May 7, 2024

max-cx Mar 22, 2022 •

edited

Loading

max-cx Mar 23, 2022 •

edited

Loading

dkwon17 Mar 28, 2022 •

edited

Loading