feat: add advanced options widget #1151

olexii4 · 2024-07-22T13:24:45Z

What does this PR do?

Add advanced options widget.

Import from a Git repository

Workspace Details

What issues does this PR fix or reference?

fixes eclipse-che/che#22975
fixes eclipse-che/che#23016

Is it tested? How?

Deploy Eclipse Che and run command to patch the CR:

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

Import a Git repo URL https://dev.azure.com/marioloriedo/publicproject/_git/public-repo?version=GBtest/branchon the Create Workspace page
2.1. Open Git repo Options and change branch from test/branch to main
2.2. Open Advanced Options and change cpuLimit to 2 and memoryLimit to 4Gi
2.3. Click Continue to continue creating a new workspace.
Open Workspace Details page. It should include all custom values.

...
projects:
 - name: public-repo
   git:
     remotes:
       origin: https://dev.azure.com/marioloriedo/publicproject/_git/public-repo
     checkoutFrom:
       revision: main
components:
 - name: tools
   container:
     image: quay.io/devfile/universal-developer-image...
     memoryLimit: 4Gi
     cpuLimit: '2'
...

Release Notes

Docs PR

che-bot · 2024-07-22T13:24:58Z

Click here to review and test in web IDE:

github-actions · 2024-07-22T14:22:09Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

...ashboard-frontend/src/components/ImportFromGit/AdvancedOptions/ContainerImageField/index.tsx

...ages/dashboard-frontend/src/components/ImportFromGit/AdvancedOptions/CpuLimitField/index.tsx

github-actions · 2024-07-30T03:51:22Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-07-31T13:51:35Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-01T00:06:24Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-01T13:14:55Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-01T23:40:49Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-02T00:03:13Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-02T00:25:05Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-02T02:50:24Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-03T22:10:34Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-04T23:19:41Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

github-actions · 2024-08-05T02:15:45Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1151

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1151", name: che-dashboard}]}}]"

dmytro-ndp · 2024-08-05T14:29:19Z

@olexii4 : hello,
Test scenario described in the PR description had passed as expected with Eclipse Che Next using quay.io/eclipse/che-dashboard:pr-1151

At the same time I have noticed few issues:

Workspace didn't seem respect changes in limits in the Workspace details > Devfile. ResourceMonitor

schemaVersion: 2.1.0
metadata:
  name: nodejs-react
components:
  - name: tools
    container:
      image: quay.io/devfile/universal-developer-image@sha256:80fdd1ae37d3b9e0260d9c66b4ff12e35317c31243eabeea5212d98c537a3ba9 # upstream - 3.7GB compressed
      # image: registry.redhat.io/devspaces/udi-rhel8:latest #1.7GB compressed
      # volumeMounts:
      #   - name: m2
      #     path: /home/user/.m2
      memoryLimit: 6Gi
      memoryRequest: 1Gi
      cpuRequest: '1'
      cpuLimit: '3'
      mountSources: true
      # image: registry.redhat.io/devspaces/udi-rhel8:latest

I have got function Error() {[native code]} when tried to fix wrong "remoteURL" value within the Git repo URL field:
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.08.05-17_18_13.webm
Advanced Options > Create New If Existing option needs more context, IMHO, like Create New Workspace If there is the one with the same name Existing:
It's not clear which particular workspace container the Container Image option will be applied to, if there are several containers defined in the devfile, like https://github.com/devspaces-samples/nodejs-mongodb-sample/blob/devspaces-3-rhel-8/devfile.yaml

olexii4 · 2024-08-06T08:40:24Z

....
4. It's not clear which particular workspace container the Container Image option will be applied to, if there are several containers defined in the devfile, like https://github.com/devspaces-samples/nodejs-mongodb-sample/blob/devspaces-3-rhel-8/devfile.yaml

@dmytro-ndp : We have che-docs with a good description:

...
You can use the image parameter to use a custom reference to a container image in the following scenarios:

 - The Git repository contains no devfile, and you want to start a new workspace with the custom image.

 - The Git repository contains a devfile, and you want to override the first container image listed in the components section of the devfile.
...

Signed-off-by: Oleksii Orel <oorel@redhat.com>

devstudio-release · 2024-08-13T08:16:06Z

Build 3.17 :: dashboard_3.x/523: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:16:06Z

Build 3.16 :: dashboard_3.16/7: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:20:31Z

Build 3.17 :: sync-to-downstream_3.x/7445: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:21:13Z

Build 3.16 :: sync-to-downstream_3.16/14: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:22:19Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7427: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:22:22Z

Build 3.16 :: get-sources-rhpkg-container-build_3.16/14: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:51:45Z

Build 3.16 :: push-latest-container-to-quay_3.16/14: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:53:54Z

Build 3.17 :: push-latest-container-to-quay_3.x/4868: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:56:12Z

Build 3.16 :: get-sources-rhpkg-container-build_3.16/14:

dashboard : 3.16 :: Build 63302802 : quay.io/devspaces/dashboard-rhel8:3.16-20
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.16/14 triggered

devstudio-release · 2024-08-13T08:56:14Z

Build 3.16 :: update-digests_3.16/40: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:56:15Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7427:

dashboard : 3.x :: Build 63302801 : quay.io/devspaces/dashboard-rhel8:3.17-4
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4868 triggered

devstudio-release · 2024-08-13T08:56:15Z

Build 3.16 :: dashboard_3.16/7:

Upstream sync done; /DS_CI/sync-to-downstream_3.16/14 triggered

devstudio-release · 2024-08-13T08:56:18Z

Build 3.17 :: dashboard_3.x/523:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7445 triggered

devstudio-release · 2024-08-13T08:56:18Z

Build 3.17 :: update-digests_3.x/7306: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:57:11Z

Build 3.16 :: operator-bundle_3.16/7: Console, Changes, Git Data

devstudio-release · 2024-08-13T08:57:16Z

Build 3.17 :: operator-bundle_3.x/3435: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:02:46Z

Build 3.16 :: sync-to-downstream_3.16/15: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:03:17Z

Build 3.16 :: get-sources-rhpkg-container-build_3.16/15: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:03:42Z

Build 3.17 :: sync-to-downstream_3.x/7446: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:09:00Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7428: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:11:00Z

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7428:

devspaces-operator-bundle : 3.x :: Failed in 63303701 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

devstudio-release · 2024-08-13T09:11:02Z

Build 3.16 :: push-latest-container-to-quay_3.16/15: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:13:47Z

Build 3.16 :: copyIIBsToQuay/2750: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:14:35Z

Build 3.16 :: get-sources-rhpkg-container-build_3.16/15:

devspaces-operator-bundle : 3.16 :: Build 63303667 : quay.io/devspaces/devspaces-operator-bundle:3.16-45
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.16/15 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.16-16
- quay.io/devspaces/configbump-rhel8:3.16-2
- quay.io/devspaces/dashboard-rhel8:3.16-20
- quay.io/devspaces/devfileregistry-rhel8:3.16-61
- quay.io/devspaces/devspaces-rhel8-operator:3.16-7
- quay.io/devspaces/idea-rhel8:3.16-7
- quay.io/devspaces/pluginregistry-rhel8:3.16-10
- quay.io/devspaces/server-rhel8:3.16-12
- quay.io/devspaces/traefik-rhel8:3.16-1
- quay.io/devspaces/udi-rhel8:3.16-4
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202407151105.p0.gb17014f.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202407151105.p0.g03e5b13.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devstudio-release · 2024-08-13T09:14:37Z

Build 3.16 :: sync-to-downstream_3.16/15:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.16/15 triggered; /job/DS_CI/job/dsc_3.16 triggered;

devstudio-release · 2024-08-13T09:14:38Z

Build 3.16 :: operator-bundle_3.16/7:

Upstream sync done; /DS_CI/sync-to-downstream_3.16/15 triggered

devstudio-release · 2024-08-13T09:15:36Z

Build 3.16 :: dsc_3.16/8: Console, Changes, Git Data

devstudio-release · 2024-08-13T09:16:24Z

Build 3.16 :: update-digests_3.16/40:

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.16/7 triggered

devstudio-release · 2024-08-13T09:25:04Z

Build 3.16 :: dsc_3.16/8:

3.16.0-CI

devstudio-release · 2024-08-13T10:18:01Z

Build 3.16 :: copyIIBsToQuay/2750:

3.16
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.16-45
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.16-v4.16-787199-s390x
  + quay.io/devspaces/iib:3.16-v4.16-s390x
  + quay.io/devspaces/iib:latest-v4.16-s390x
  + quay.io/devspaces/iib:3.16-v4.15-788089-s390x
  + quay.io/devspaces/iib:3.16-v4.15-s390x
  + quay.io/devspaces/iib:latest-v4.15-s390x
  + quay.io/devspaces/iib:3.16-v4.14-788095-s390x
  + quay.io/devspaces/iib:3.16-v4.14-s390x
  + quay.io/devspaces/iib:latest-v4.14-s390x
  + quay.io/devspaces/iib:3.16-v4.13-788088-s390x
  + quay.io/devspaces/iib:3.16-v4.13-s390x
  + quay.io/devspaces/iib:latest-v4.13-s390x
  + quay.io/devspaces/iib:3.16-v4.12-788087-s390x
  + quay.io/devspaces/iib:3.16-v4.12-s390x
  + quay.io/devspaces/iib:latest-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.16-v4.16-787199-x86_64
  + quay.io/devspaces/iib:3.16-v4.16-x86_64
  + quay.io/devspaces/iib:latest-v4.16-x86_64
  + quay.io/devspaces/iib:3.16-v4.15-788089-x86_64
  + quay.io/devspaces/iib:3.16-v4.15-x86_64
  + quay.io/devspaces/iib:latest-v4.15-x86_64
  + quay.io/devspaces/iib:3.16-v4.14-788095-x86_64
  + quay.io/devspaces/iib:3.16-v4.14-x86_64
  + quay.io/devspaces/iib:latest-v4.14-x86_64
  + quay.io/devspaces/iib:3.16-v4.13-788088-x86_64
  + quay.io/devspaces/iib:3.16-v4.13-x86_64
  + quay.io/devspaces/iib:latest-v4.13-x86_64
  + quay.io/devspaces/iib:3.16-v4.12-788087-x86_64
  + quay.io/devspaces/iib:3.16-v4.12-x86_64
  + quay.io/devspaces/iib:latest-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.16-v4.16-787199-ppc64le
  + quay.io/devspaces/iib:3.16-v4.16-ppc64le
  + quay.io/devspaces/iib:latest-v4.16-ppc64le
  + quay.io/devspaces/iib:3.16-v4.15-788089-ppc64le
  + quay.io/devspaces/iib:3.16-v4.15-ppc64le
  + quay.io/devspaces/iib:latest-v4.15-ppc64le
  + quay.io/devspaces/iib:3.16-v4.14-788095-ppc64le
  + quay.io/devspaces/iib:3.16-v4.14-ppc64le
  + quay.io/devspaces/iib:latest-v4.14-ppc64le
  + quay.io/devspaces/iib:3.16-v4.13-788088-ppc64le
  + quay.io/devspaces/iib:3.16-v4.13-ppc64le
  + quay.io/devspaces/iib:latest-v4.13-ppc64le
  + quay.io/devspaces/iib:3.16-v4.12-788087-ppc64le
  + quay.io/devspaces/iib:3.16-v4.12-ppc64le
  + quay.io/devspaces/iib:latest-v4.12-ppc64le

olexii4 requested review from akurinnoy and ibuziuk as code owners July 22, 2024 13:24

akurinnoy reviewed Jul 24, 2024

View reviewed changes

olexii4 force-pushed the CHE-22975 branch from 6d73505 to f3bbff4 Compare July 30, 2024 03:43

eclipse-che deleted a comment from codecov bot Aug 1, 2024

olexii4 force-pushed the CHE-22975 branch from 7634f5f to b6b7988 Compare August 1, 2024 23:53

eclipse-che deleted a comment from codecov bot Aug 3, 2024

olexii4 force-pushed the CHE-22975 branch from e502574 to c5ba67a Compare August 4, 2024 23:11

eclipse-che deleted a comment from codecov bot Aug 5, 2024

olexii4 added 5 commits August 6, 2024 15:25

feat: add advanced options widget

1285983

Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat: add azure branch detection

090aa10

Signed-off-by: Oleksii Orel <oorel@redhat.com>

fixup! feat: add azure branch detection

f6d0d29

fixup! fixup! feat: add azure branch detection

c42b1da

Signed-off-by: Oleksii Orel <oorel@redhat.com>

fixup! fixup! fixup! feat: add azure branch detection

4cb9594

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-22975 branch from 4a15bc4 to 4cb9594 Compare August 6, 2024 12:33

feat: add advanced options widget #1151

feat: add advanced options widget #1151

Conversation

olexii4 commented Jul 22, 2024 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

che-bot commented Jul 22, 2024

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 30, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 3, 2024

github-actions bot commented Aug 4, 2024

github-actions bot commented Aug 5, 2024

dmytro-ndp commented Aug 5, 2024

olexii4 commented Aug 6, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

devstudio-release commented Aug 13, 2024

olexii4 commented Jul 22, 2024 •

edited

Loading